( )⚙ D11557 dirstate-item: change the internal storage and constructor value

This is an archive of the discontinued Mercurial Phabricator instance.

dirstate-item: change the internal storage and constructor value

Authored by marmoute on Oct 1 2021, 2:40 PM.



This should be closer to what we do need and what we can actually reliably

In practice it means that we abandon the prospect of storing much more refined
data for now. We don't have the necessary information nor code using it right
now. So it seems safer to just use a clearer version of what we had so far.

See the documentation changes for details.

Diff Detail

rHG Mercurial
No Linters Available
No Unit Test Coverage

Event Timeline

marmoute created this revision.Oct 1 2021, 2:40 PM
baymax updated this revision to Diff 30549.Oct 1 2021, 6:04 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute updated this revision to Diff 30579.Oct 2 2021, 8:39 PM
Alphare accepted this revision.Oct 3 2021, 4:57 PM
Alphare added a subscriber: Alphare.
Alphare added inline comments.

Could be worthwhile to add a comment saying that this makes sense semantically because both the mode and size would be None together. But this could also be a follow-up


I don't think returning an Option here would be valuable, IMO panicking is the right choice

This revision is now accepted and ready to land.Oct 3 2021, 4:57 PM