This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11570

dirstatemap: create `_dirs_incr/_dirs_decr` methods on the common class
ClosedPublic

Authored by marmoute on Oct 2 2021, 11:05 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGde793f249852: dirstatemap: create `_dirs_incr/_dirs_decr` methods on the common class
Summary

The Rust wrapper does not need them. However having a default, no-op,
implementation will help use to write code used by both implementation.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 2 2021, 11:05 AM
Alphare accepted this revision.Oct 3 2021, 4:11 PM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
mercurial/dirstatemap.py
88

s/incremente/increment/, safe for "decrement" below. Also "the dirstate counter" is a little vague, this could be a follow-up.

This revision is now accepted and ready to land.Oct 3 2021, 4:11 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstatemap.py (19 lines)

Diff 30627

mercurial/dirstatemap.py

return iter(self._map) return iter(self._map)
def __contains__(self, key): def __contains__(self, key):
return key in self._map return key in self._map
def __getitem__(self, item): def __getitem__(self, item):
return self._map[item] return self._map[item]
### sub-class utility method
#
# Use to allow for generic implementation of some method while still coping
# with minor difference between implementation.
def _dirs_incr(self, filename, old_entry=None):
"""incremente the dirstate counter if applicable
AlphareUnsubmitted
Not Done

s/incremente/increment/, safe for "decrement" below. Also "the dirstate counter" is a little vague, this could be a follow-up.

Alphare: s/incremente/increment/, safe for "decrement" below. Also "the dirstate counter" is a little…
This might be a no-op for some subclass who deal with directory
tracking in a different way.
"""
def _dirs_decr(self, filename, old_entry=None, remove_variant=False):
"""decremente the dirstate counter if applicable
This might be a no-op for some subclass who deal with directory
tracking in a different way.
"""
class dirstatemap(_dirstatemapcommon): class dirstatemap(_dirstatemapcommon):
"""Map encapsulating the dirstate's contents. """Map encapsulating the dirstate's contents.
The dirstate contains the following state: The dirstate contains the following state:
- `identity` is the identity of the dirstate file, which can be used to - `identity` is the identity of the dirstate file, which can be used to
detect when changes have occurred to the dirstate file. detect when changes have occurred to the dirstate file.