Page MenuHomePhabricator

pytype: stop excluding upgrade.py
ClosedPublic

Authored by mharbison72 on Dec 14 2021, 4:10 PM.

Details

Summary

The sole failure here was this, which is fixed by simply creating a set like the
caller, instead of a dict:

File "/mnt/c/Users/Matt/hg/mercurial/upgrade.py", line 73, in upgraderepo:
    No attribute 'discard' on Dict[nothing, nothing] [attribute-error]
  In Union[Any, Dict[nothing, nothing]]

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 14 2021, 4:10 PM
Alphare accepted this revision.Dec 15 2021, 4:51 AM
This revision is now accepted and ready to land.Dec 15 2021, 4:51 AM
This revision was automatically updated to reflect the committed changes.