| Alphare |
| hg-reviewers |
I can't prove that targetrev is always in all_copies, but it would have been
a runtime error before too if it's not.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/copies.py (6 lines) | |||
| M | tests/test-check-pytype.t (2 lines) |
| Status | Author | Revision | |
|---|---|---|---|
| Closed | mharbison72 | ||
| Closed | mharbison72 | ||
| Closed | mharbison72 | ||
| Closed | mharbison72 | ||
| Closed | mharbison72 | ||
| Closed | mharbison72 | ||
| Closed | mharbison72 | ||
| Closed | mharbison72 | ||
| Closed | mharbison72 | ||
| Closed | mharbison72 | ||
| Closed | mharbison72 | ||
| Closed | mharbison72 | ||
| Closed | mharbison72 | ||
| Closed | mharbison72 |
| isancestor, | isancestor, | ||||
| changes, | changes, | ||||
| current_rev, | current_rev, | ||||
| ) | ) | ||||
| all_copies[current_rev] = current_copies | all_copies[current_rev] = current_copies | ||||
| # filter out internal details and return a {dest: source mapping} | # filter out internal details and return a {dest: source mapping} | ||||
| final_copies = {} | final_copies = {} | ||||
| for dest, (tt, source) in all_copies[targetrev].items(): | |||||
| targetrev_items = all_copies[targetrev] | |||||
| assert targetrev_items is not None # help pytype | |||||
| for dest, (tt, source) in targetrev_items.items(): | |||||
| if source is not None: | if source is not None: | ||||
| final_copies[dest] = source | final_copies[dest] = source | ||||
| if not alwaysmatch: | if not alwaysmatch: | ||||
| for filename in list(final_copies.keys()): | for filename in list(final_copies.keys()): | ||||
| if not match(filename): | if not match(filename): | ||||
| del final_copies[filename] | del final_copies[filename] | ||||
| return final_copies | return final_copies | ||||
| #require pytype py3 slow | #require pytype py3 slow | ||||
| $ cd $RUNTESTDIR/.. | $ cd $RUNTESTDIR/.. | ||||
| Many of the individual files that are excluded here confuse pytype | Many of the individual files that are excluded here confuse pytype | ||||
| because they do a mix of Python 2 and Python 3 things | because they do a mix of Python 2 and Python 3 things | ||||
| conditionally. There's no good way to help it out with that as far as | conditionally. There's no good way to help it out with that as far as | ||||
| I can tell, so let's just hide those files from it for now. We should | I can tell, so let's just hide those files from it for now. We should | ||||
| endeavor to empty this list out over time, as some of these are | endeavor to empty this list out over time, as some of these are | ||||
| probably hiding real problems. | probably hiding real problems. | ||||
| mercurial/bundlerepo.py # no vfs and ui attrs on bundlerepo | mercurial/bundlerepo.py # no vfs and ui attrs on bundlerepo | ||||
| mercurial/chgserver.py # [attribute-error] | mercurial/chgserver.py # [attribute-error] | ||||
| mercurial/cmdutil.py # No attribute 'markcopied' on mercurial.context.filectx [attribute-error] | mercurial/cmdutil.py # No attribute 'markcopied' on mercurial.context.filectx [attribute-error] | ||||
| mercurial/context.py # many [attribute-error] | mercurial/context.py # many [attribute-error] | ||||
| mercurial/copies.py # No attribute 'items' on None [attribute-error] | |||||
| mercurial/crecord.py # tons of [attribute-error], [module-attr] | mercurial/crecord.py # tons of [attribute-error], [module-attr] | ||||
| mercurial/debugcommands.py # [wrong-arg-types] | mercurial/debugcommands.py # [wrong-arg-types] | ||||
| mercurial/dispatch.py # initstdio: No attribute ... on TextIO [attribute-error] | mercurial/dispatch.py # initstdio: No attribute ... on TextIO [attribute-error] | ||||
| mercurial/exchange.py # [attribute-error] | mercurial/exchange.py # [attribute-error] | ||||
| mercurial/hgweb/hgweb_mod.py # [attribute-error], [name-error], [wrong-arg-types] | mercurial/hgweb/hgweb_mod.py # [attribute-error], [name-error], [wrong-arg-types] | ||||
| mercurial/hgweb/server.py # [attribute-error], [name-error], [module-attr] | mercurial/hgweb/server.py # [attribute-error], [name-error], [module-attr] | ||||
| mercurial/hgweb/webcommands.py # [missing-parameter] | mercurial/hgweb/webcommands.py # [missing-parameter] | ||||
| mercurial/hgweb/wsgicgi.py # confused values in os.environ | mercurial/hgweb/wsgicgi.py # confused values in os.environ | ||||
| TODO: use --no-cache on test server? Caching the files locally helps during | TODO: use --no-cache on test server? Caching the files locally helps during | ||||
| development, but may be a hinderance for CI testing. | development, but may be a hinderance for CI testing. | ||||
| $ pytype -V 3.6 --keep-going --jobs auto mercurial \ | $ pytype -V 3.6 --keep-going --jobs auto mercurial \ | ||||
| > -x mercurial/bundlerepo.py \ | > -x mercurial/bundlerepo.py \ | ||||
| > -x mercurial/chgserver.py \ | > -x mercurial/chgserver.py \ | ||||
| > -x mercurial/cmdutil.py \ | > -x mercurial/cmdutil.py \ | ||||
| > -x mercurial/context.py \ | > -x mercurial/context.py \ | ||||
| > -x mercurial/copies.py \ | |||||
| > -x mercurial/crecord.py \ | > -x mercurial/crecord.py \ | ||||
| > -x mercurial/debugcommands.py \ | > -x mercurial/debugcommands.py \ | ||||
| > -x mercurial/dispatch.py \ | > -x mercurial/dispatch.py \ | ||||
| > -x mercurial/exchange.py \ | > -x mercurial/exchange.py \ | ||||
| > -x mercurial/hgweb/hgweb_mod.py \ | > -x mercurial/hgweb/hgweb_mod.py \ | ||||
| > -x mercurial/hgweb/server.py \ | > -x mercurial/hgweb/server.py \ | ||||
| > -x mercurial/hgweb/webcommands.py \ | > -x mercurial/hgweb/webcommands.py \ | ||||
| > -x mercurial/hgweb/wsgicgi.py \ | > -x mercurial/hgweb/wsgicgi.py \ | ||||