This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11922

pytype: stop excluding patch.py
ClosedPublic

Authored by mharbison72 on Dec 14 2021, 4:11 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG290f9c150f70: pytype: stop excluding patch.py
Summary

The underlying email.generator.BytesGenerator is documented as requiring an
fp that accepts bytes, so I'm not sure why pytype is getting confused:

File "/mnt/c/Users/Matt/hg/mercurial/patch.py", line 112, in msgfp:
    Function Generator.__init__ was called with the wrong arguments [wrong-arg-types]
         Expected: (self, outfp: TextIO, ...)
  Actually passed: (self, outfp: io.BytesIO, ...)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 14 2021, 4:11 PM
Alphare accepted this revision.Dec 15 2021, 5:28 AM
This revision is now accepted and ready to land.Dec 15 2021, 5:28 AM
mharbison72 added a commit: rHG290f9c150f70: pytype: stop excluding patch.py.Dec 17 2021, 6:10 AM
Closed by commit rHG290f9c150f70: pytype: stop excluding patch.py (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/patch.py (2 lines)
Mtests/test-check-pytype.t (2 lines)

Diff 31515

mercurial/patch.py

if cur: if cur:
for c in split(chunk(cur[1:])): for c in split(chunk(cur[1:])):
yield c yield c
def mimesplit(stream, cur): def mimesplit(stream, cur):
def msgfp(m): def msgfp(m):
fp = stringio() fp = stringio()
# pytype: disable=wrong-arg-types
g = mail.Generator(fp, mangle_from_=False) g = mail.Generator(fp, mangle_from_=False)
# pytype: enable=wrong-arg-types
g.flatten(m) g.flatten(m)
fp.seek(0) fp.seek(0)
return fp return fp
for line in stream: for line in stream:
cur.append(line) cur.append(line)
c = chunk(cur) c = chunk(cur)

tests/test-check-pytype.t

mercurial/hgweb/webcommands.py # [missing-parameter] mercurial/hgweb/webcommands.py # [missing-parameter]
mercurial/hgweb/wsgicgi.py # confused values in os.environ mercurial/hgweb/wsgicgi.py # confused values in os.environ
mercurial/httppeer.py # [attribute-error], [wrong-arg-types] mercurial/httppeer.py # [attribute-error], [wrong-arg-types]
mercurial/interfaces # No attribute 'capabilities' on peer [attribute-error] mercurial/interfaces # No attribute 'capabilities' on peer [attribute-error]
mercurial/keepalive.py # [attribute-error] mercurial/keepalive.py # [attribute-error]
mercurial/localrepo.py # [attribute-error] mercurial/localrepo.py # [attribute-error]
mercurial/manifest.py # [unsupported-operands], [wrong-arg-types] mercurial/manifest.py # [unsupported-operands], [wrong-arg-types]
mercurial/minirst.py # [unsupported-operands], [attribute-error] mercurial/minirst.py # [unsupported-operands], [attribute-error]
mercurial/patch.py # [wrong-arg-types]
mercurial/pure/osutil.py # [invalid-typevar], [not-callable] mercurial/pure/osutil.py # [invalid-typevar], [not-callable]
mercurial/pure/parsers.py # [attribute-error] mercurial/pure/parsers.py # [attribute-error]
mercurial/pycompat.py # bytes vs str issues mercurial/pycompat.py # bytes vs str issues
mercurial/repoview.py # [attribute-error] mercurial/repoview.py # [attribute-error]
mercurial/sslutil.py # [attribute-error] mercurial/sslutil.py # [attribute-error]
mercurial/testing/storage.py # tons of [attribute-error] mercurial/testing/storage.py # tons of [attribute-error]
mercurial/ui.py # [attribute-error], [wrong-arg-types] mercurial/ui.py # [attribute-error], [wrong-arg-types]
mercurial/unionrepo.py # ui, svfs, unfiltered [attribute-error] mercurial/unionrepo.py # ui, svfs, unfiltered [attribute-error]
> -x mercurial/hgweb/webcommands.py \ > -x mercurial/hgweb/webcommands.py \
> -x mercurial/hgweb/wsgicgi.py \ > -x mercurial/hgweb/wsgicgi.py \
> -x mercurial/httppeer.py \ > -x mercurial/httppeer.py \
> -x mercurial/interfaces \ > -x mercurial/interfaces \
> -x mercurial/keepalive.py \ > -x mercurial/keepalive.py \
> -x mercurial/localrepo.py \ > -x mercurial/localrepo.py \
> -x mercurial/manifest.py \ > -x mercurial/manifest.py \
> -x mercurial/minirst.py \ > -x mercurial/minirst.py \
> -x mercurial/patch.py \
> -x mercurial/pure/osutil.py \ > -x mercurial/pure/osutil.py \
> -x mercurial/pure/parsers.py \ > -x mercurial/pure/parsers.py \
> -x mercurial/pycompat.py \ > -x mercurial/pycompat.py \
> -x mercurial/repoview.py \ > -x mercurial/repoview.py \
> -x mercurial/sslutil.py \ > -x mercurial/sslutil.py \
> -x mercurial/testing/storage.py \ > -x mercurial/testing/storage.py \
> -x mercurial/thirdparty \ > -x mercurial/thirdparty \
> -x mercurial/ui.py \ > -x mercurial/ui.py \