Page MenuHomePhabricator

pytype: stop excluding patch.py
ClosedPublic

Authored by mharbison72 on Dec 14 2021, 4:11 PM.

Details

Summary

The underlying email.generator.BytesGenerator is documented as requiring an
fp that accepts bytes, so I'm not sure why pytype is getting confused:

File "/mnt/c/Users/Matt/hg/mercurial/patch.py", line 112, in msgfp:
    Function Generator.__init__ was called with the wrong arguments [wrong-arg-types]
         Expected: (self, outfp: TextIO, ...)
  Actually passed: (self, outfp: io.BytesIO, ...)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 14 2021, 4:11 PM
Alphare accepted this revision.Dec 15 2021, 5:28 AM
This revision is now accepted and ready to land.Dec 15 2021, 5:28 AM
This revision was automatically updated to reflect the committed changes.