( )⚙ D11911 pytype: stop excluding upgrade.py

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11911

pytype: stop excluding upgrade.py
ClosedPublic

Authored by mharbison72 on Dec 14 2021, 4:10 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGa4d8de93023c: pytype: stop excluding upgrade.py
Summary

The sole failure here was this, which is fixed by simply creating a set like the
caller, instead of a dict:

File "/mnt/c/Users/Matt/hg/mercurial/upgrade.py", line 73, in upgraderepo:
    No attribute 'discard' on Dict[nothing, nothing] [attribute-error]
  In Union[Any, Dict[nothing, nothing]]

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Dec 14 2021, 4:10 PM
Alphare accepted this revision.Dec 15 2021, 4:51 AM
This revision is now accepted and ready to land.Dec 15 2021, 4:51 AM
mharbison72 added a commit: rHGa4d8de93023c: pytype: stop excluding upgrade.py.Dec 17 2021, 6:09 AM
Closed by commit rHGa4d8de93023c: pytype: stop excluding upgrade.py (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/upgrade.py (2 lines)
Mtests/test-check-pytype.t (2 lines)

Diff 31468

mercurial/upgrade.py

optimize=None, optimize=None,
backup=True, backup=True,
manifest=None, manifest=None,
changelog=None, changelog=None,
filelogs=None, filelogs=None,
): ):
"""Upgrade a repository in place.""" """Upgrade a repository in place."""
if optimize is None: if optimize is None:
optimize = {} optimize = set()
repo = repo.unfiltered() repo = repo.unfiltered()
specified_revlogs = {} specified_revlogs = {}
if changelog is not None: if changelog is not None:
specified_revlogs[upgrade_engine.UPGRADE_CHANGELOG] = changelog specified_revlogs[upgrade_engine.UPGRADE_CHANGELOG] = changelog
if manifest is not None: if manifest is not None:
specified_revlogs[upgrade_engine.UPGRADE_MANIFEST] = manifest specified_revlogs[upgrade_engine.UPGRADE_MANIFEST] = manifest
if filelogs is not None: if filelogs is not None:

tests/test-check-pytype.t

mercurial/pure/parsers.py # [attribute-error] mercurial/pure/parsers.py # [attribute-error]
mercurial/pycompat.py # bytes vs str issues mercurial/pycompat.py # bytes vs str issues
mercurial/repoview.py # [attribute-error] mercurial/repoview.py # [attribute-error]
mercurial/sslutil.py # [attribute-error] mercurial/sslutil.py # [attribute-error]
mercurial/statprof.py # bytes vs str on TextIO.write() [wrong-arg-types] mercurial/statprof.py # bytes vs str on TextIO.write() [wrong-arg-types]
mercurial/testing/storage.py # tons of [attribute-error] mercurial/testing/storage.py # tons of [attribute-error]
mercurial/ui.py # [attribute-error], [wrong-arg-types] mercurial/ui.py # [attribute-error], [wrong-arg-types]
mercurial/unionrepo.py # ui, svfs, unfiltered [attribute-error] mercurial/unionrepo.py # ui, svfs, unfiltered [attribute-error]
mercurial/upgrade.py # line 84, in upgraderepo: No attribute 'discard' on Dict[nothing, nothing] [attribute-error]
mercurial/util.py # [attribute-error], [wrong-arg-count] mercurial/util.py # [attribute-error], [wrong-arg-count]
mercurial/utils/procutil.py # [attribute-error], [module-attr], [bad-return-type] mercurial/utils/procutil.py # [attribute-error], [module-attr], [bad-return-type]
mercurial/utils/stringutil.py # [module-attr], [wrong-arg-count] mercurial/utils/stringutil.py # [module-attr], [wrong-arg-count]
mercurial/utils/memorytop.py # not 3.6 compatible mercurial/utils/memorytop.py # not 3.6 compatible
mercurial/win32.py # [not-callable] mercurial/win32.py # [not-callable]
mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error] mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error]
mercurial/wireprotoserver.py # line 253, in _availableapis: No attribute '__iter__' on Callable[[Any, Any], Any] [attribute-error] mercurial/wireprotoserver.py # line 253, in _availableapis: No attribute '__iter__' on Callable[[Any, Any], Any] [attribute-error]
mercurial/wireprotov1peer.py # [attribute-error] mercurial/wireprotov1peer.py # [attribute-error]
> -x mercurial/pycompat.py \ > -x mercurial/pycompat.py \
> -x mercurial/repoview.py \ > -x mercurial/repoview.py \
> -x mercurial/sslutil.py \ > -x mercurial/sslutil.py \
> -x mercurial/statprof.py \ > -x mercurial/statprof.py \
> -x mercurial/testing/storage.py \ > -x mercurial/testing/storage.py \
> -x mercurial/thirdparty \ > -x mercurial/thirdparty \
> -x mercurial/ui.py \ > -x mercurial/ui.py \
> -x mercurial/unionrepo.py \ > -x mercurial/unionrepo.py \
> -x mercurial/upgrade.py \
> -x mercurial/utils/procutil.py \ > -x mercurial/utils/procutil.py \
> -x mercurial/utils/stringutil.py \ > -x mercurial/utils/stringutil.py \
> -x mercurial/utils/memorytop.py \ > -x mercurial/utils/memorytop.py \
> -x mercurial/win32.py \ > -x mercurial/win32.py \
> -x mercurial/wireprotoframing.py \ > -x mercurial/wireprotoframing.py \
> -x mercurial/wireprotoserver.py \ > -x mercurial/wireprotoserver.py \
> -x mercurial/wireprotov1peer.py \ > -x mercurial/wireprotov1peer.py \
> -x mercurial/wireprotov1server.py \ > -x mercurial/wireprotov1server.py \
> -x mercurial/wireprotov2server.py \ > -x mercurial/wireprotov2server.py \
> > $TESTTMP/pytype-output.txt || cat $TESTTMP/pytype-output.txt > > $TESTTMP/pytype-output.txt || cat $TESTTMP/pytype-output.txt
Only show the results on a failure, because the output on success is also Only show the results on a failure, because the output on success is also
voluminous and variable. voluminous and variable.