( )⚙ D11917 pytype: stop excluding cmdutil.py

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11917

pytype: stop excluding cmdutil.py
ClosedPublic

Authored by mharbison72 on Dec 14 2021, 4:10 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG3444e0b39c30: pytype: stop excluding cmdutil.py
Summary

Whatever was broken here seems to have been previously fixed.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 14 2021, 4:10 PM
Alphare accepted this revision.Dec 15 2021, 5:10 AM
This revision is now accepted and ready to land.Dec 15 2021, 5:10 AM
mharbison72 added a commit: rHG3444e0b39c30: pytype: stop excluding cmdutil.py.Dec 17 2021, 6:10 AM
Closed by commit rHG3444e0b39c30: pytype: stop excluding cmdutil.py (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-check-pytype.t (2 lines)

Diff 31511

tests/test-check-pytype.t

#require pytype py3 slow #require pytype py3 slow
$ cd $RUNTESTDIR/.. $ cd $RUNTESTDIR/..
Many of the individual files that are excluded here confuse pytype Many of the individual files that are excluded here confuse pytype
because they do a mix of Python 2 and Python 3 things because they do a mix of Python 2 and Python 3 things
conditionally. There's no good way to help it out with that as far as conditionally. There's no good way to help it out with that as far as
I can tell, so let's just hide those files from it for now. We should I can tell, so let's just hide those files from it for now. We should
endeavor to empty this list out over time, as some of these are endeavor to empty this list out over time, as some of these are
probably hiding real problems. probably hiding real problems.
mercurial/bundlerepo.py # no vfs and ui attrs on bundlerepo mercurial/bundlerepo.py # no vfs and ui attrs on bundlerepo
mercurial/chgserver.py # [attribute-error] mercurial/chgserver.py # [attribute-error]
mercurial/cmdutil.py # No attribute 'markcopied' on mercurial.context.filectx [attribute-error]
mercurial/context.py # many [attribute-error] mercurial/context.py # many [attribute-error]
mercurial/crecord.py # tons of [attribute-error], [module-attr] mercurial/crecord.py # tons of [attribute-error], [module-attr]
mercurial/debugcommands.py # [wrong-arg-types] mercurial/debugcommands.py # [wrong-arg-types]
mercurial/dispatch.py # initstdio: No attribute ... on TextIO [attribute-error] mercurial/dispatch.py # initstdio: No attribute ... on TextIO [attribute-error]
mercurial/exchange.py # [attribute-error] mercurial/exchange.py # [attribute-error]
mercurial/hgweb/hgweb_mod.py # [attribute-error], [name-error], [wrong-arg-types] mercurial/hgweb/hgweb_mod.py # [attribute-error], [name-error], [wrong-arg-types]
mercurial/hgweb/server.py # [attribute-error], [name-error], [module-attr] mercurial/hgweb/server.py # [attribute-error], [name-error], [module-attr]
mercurial/hgweb/webcommands.py # [missing-parameter] mercurial/hgweb/webcommands.py # [missing-parameter]
mercurial/wireprotov2server.py # [unsupported-operands], [attribute-error] mercurial/wireprotov2server.py # [unsupported-operands], [attribute-error]
TODO: use --no-cache on test server? Caching the files locally helps during TODO: use --no-cache on test server? Caching the files locally helps during
development, but may be a hinderance for CI testing. development, but may be a hinderance for CI testing.
$ pytype -V 3.6 --keep-going --jobs auto mercurial \ $ pytype -V 3.6 --keep-going --jobs auto mercurial \
> -x mercurial/bundlerepo.py \ > -x mercurial/bundlerepo.py \
> -x mercurial/chgserver.py \ > -x mercurial/chgserver.py \
> -x mercurial/cmdutil.py \
> -x mercurial/context.py \ > -x mercurial/context.py \
> -x mercurial/crecord.py \ > -x mercurial/crecord.py \
> -x mercurial/debugcommands.py \ > -x mercurial/debugcommands.py \
> -x mercurial/dispatch.py \ > -x mercurial/dispatch.py \
> -x mercurial/exchange.py \ > -x mercurial/exchange.py \
> -x mercurial/hgweb/hgweb_mod.py \ > -x mercurial/hgweb/hgweb_mod.py \
> -x mercurial/hgweb/server.py \ > -x mercurial/hgweb/server.py \
> -x mercurial/hgweb/webcommands.py \ > -x mercurial/hgweb/webcommands.py \