( )⚙ D11920 statprof: convert a few exception byte strings to str

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11920

statprof: convert a few exception byte strings to str
ClosedPublic

Authored by mharbison72 on Dec 14 2021, 4:10 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGc1fe758c1530: statprof: convert a few exception byte strings to str
Summary

That way these display without the b'' prefix.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Dec 14 2021, 4:10 PM
Alphare accepted this revision.Dec 15 2021, 5:25 AM
This revision is now accepted and ready to land.Dec 15 2021, 5:25 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/statprof.py (6 lines)

Diff 31477

mercurial/statprof.py

display_hotpath(data, fp, **kwargs) display_hotpath(data, fp, **kwargs)
elif format == DisplayFormats.FlameGraph: elif format == DisplayFormats.FlameGraph:
write_to_flame(data, fp, **kwargs) write_to_flame(data, fp, **kwargs)
elif format == DisplayFormats.Json: elif format == DisplayFormats.Json:
write_to_json(data, fp) write_to_json(data, fp)
elif format == DisplayFormats.Chrome: elif format == DisplayFormats.Chrome:
write_to_chrome(data, fp, **kwargs) write_to_chrome(data, fp, **kwargs)
else: else:
raise Exception(b"Invalid display format") raise Exception("Invalid display format")
if format not in (DisplayFormats.Json, DisplayFormats.Chrome): if format not in (DisplayFormats.Json, DisplayFormats.Chrome):
fp.write(b'---\n') fp.write(b'---\n')
fp.write(b'Sample count: %d\n' % len(data.samples)) fp.write(b'Sample count: %d\n' % len(data.samples))
fp.write(b'Total time: %f seconds (%f wall)\n' % data.accumulated_time) fp.write(b'Total time: %f seconds (%f wall)\n' % data.accumulated_time)
def display_by_line(data, fp): def display_by_line(data, fp):
source, source,
) )
fp.write(b'%33.0f%% %6.2f line %d: %s\n' % stattuple) fp.write(b'%33.0f%% %6.2f line %d: %s\n' % stattuple)
def display_about_method(data, fp, function=None, **kwargs): def display_about_method(data, fp, function=None, **kwargs):
if function is None: if function is None:
raise Exception(b"Invalid function") raise Exception("Invalid function")
filename = None filename = None
if b':' in function: if b':' in function:
filename, function = function.split(b':') filename, function = function.split(b':')
relevant_samples = 0 relevant_samples = 0
parents = {} parents = {}
children = {} children = {}
elif o in ("-o", "--output-file"): elif o in ("-o", "--output-file"):
displayargs[b'outputfile'] = value displayargs[b'outputfile'] = value
elif o in ("-p", "--script-path"): elif o in ("-p", "--script-path"):
displayargs[b'scriptpath'] = value displayargs[b'scriptpath'] = value
elif o in ("-h", "help"): elif o in ("-h", "help"):
printusage() printusage()
return 0 return 0
else: else:
assert False, b"unhandled option %s" % o assert False, "unhandled option %s" % o
if not path: if not path:
print('must specify --file to load') print('must specify --file to load')
return 1 return 1
load_data(path=path) load_data(path=path)
display(**pycompat.strkwargs(displayargs)) display(**pycompat.strkwargs(displayargs))
return 0 return 0
if __name__ == "__main__": if __name__ == "__main__":
sys.exit(main()) sys.exit(main())