( )⚙ D11921 pytype: stop excluding statprof.py

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11921

pytype: stop excluding statprof.py
ClosedPublic

Authored by mharbison72 on Dec 14 2021, 4:11 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGd2fff292c265: pytype: stop excluding statprof.py
Summary

This seems to have worked fine before (at least on Linux). We could just add
suppression comments, but this file already imports from the mercurial package,
which seems to prevent this from running as a standalone program because of the
relative import of pycompat. PyCharm isn't happy either way.

File "/mnt/c/Users/Matt/hg/mercurial/statprof.py", line 501, in display:
    Function TextIO.write was called with the wrong arguments [wrong-arg-types]
         Expected: (self, s: str)
  Actually passed: (self, s: bytes)
Called from (traceback):
  line 1091, in main
File "/mnt/c/Users/Matt/hg/mercurial/statprof.py", line 501, in display:
    Function TextIO.write was called with the wrong arguments [wrong-arg-types]
         Expected: (self, s: str)
  Actually passed: (self, s: bytes)
Called from (traceback):
  line 431, in profile
File "/mnt/c/Users/Matt/hg/mercurial/statprof.py", line 522, in display:
    Function TextIO.write was called with the wrong arguments [wrong-arg-types]
         Expected: (self, s: str)
  Actually passed: (self, s: bytes)
Called from (traceback):
  line 1091, in main
File "/mnt/c/Users/Matt/hg/mercurial/statprof.py", line 522, in display:
    Function TextIO.write was called with the wrong arguments [wrong-arg-types]
         Expected: (self, s: str)
  Actually passed: (self, s: bytes)
Called from (traceback):
  line 431, in profile
File "/mnt/c/Users/Matt/hg/mercurial/statprof.py", line 523, in display:
    Function TextIO.write was called with the wrong arguments [wrong-arg-types]
         Expected: (self, s: str)
  Actually passed: (self, s: bytes)
Called from (traceback):
  line 1091, in main
File "/mnt/c/Users/Matt/hg/mercurial/statprof.py", line 523, in display:
    Function TextIO.write was called with the wrong arguments [wrong-arg-types]
         Expected: (self, s: str)
  Actually passed: (self, s: bytes)
Called from (traceback):
  line 431, in profile
File "/mnt/c/Users/Matt/hg/mercurial/statprof.py", line 524, in display:
    Function TextIO.write was called with the wrong arguments [wrong-arg-types]
         Expected: (self, s: str)
  Actually passed: (self, s: bytes)
Called from (traceback):
  line 1091, in main
File "/mnt/c/Users/Matt/hg/mercurial/statprof.py", line 524, in display:
    Function TextIO.write was called with the wrong arguments [wrong-arg-types]
         Expected: (self, s: str)
  Actually passed: (self, s: bytes)
Called from (traceback):
  line 431, in profile
File "/mnt/c/Users/Matt/hg/mercurial/statprof.py", line 796, in _write:
    Function TextIO.write was called with the wrong arguments [wrong-arg-types]
         Expected: (self, s: str)
  Actually passed: (self, s: bytes)

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Dec 14 2021, 4:11 PM
Alphare accepted this revision.Dec 15 2021, 5:26 AM
Alphare added a subscriber: Alphare.

This probably also fixes some bug somewhere with stdout buffering

This revision is now accepted and ready to land.Dec 15 2021, 5:26 AM
mharbison72 added a commit: rHGd2fff292c265: pytype: stop excluding statprof.py.Dec 17 2021, 6:10 AM
Closed by commit rHGd2fff292c265: pytype: stop excluding statprof.py (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/statprof.py (4 lines)
Mtests/test-check-pytype.t (2 lines)

Diff 31478

mercurial/statprof.py

def display(fp=None, format=3, data=None, **kwargs): def display(fp=None, format=3, data=None, **kwargs):
'''Print statistics, either to stdout or the given file object.''' '''Print statistics, either to stdout or the given file object.'''
if data is None: if data is None:
data = state data = state
if fp is None: if fp is None:
import sys from .utils import procutil
fp = sys.stdout fp = procutil.stdout
if len(data.samples) == 0: if len(data.samples) == 0:
fp.write(b'No samples recorded.\n') fp.write(b'No samples recorded.\n')
return return
if format == DisplayFormats.ByLine: if format == DisplayFormats.ByLine:
display_by_line(data, fp) display_by_line(data, fp)
elif format == DisplayFormats.ByMethod: elif format == DisplayFormats.ByMethod:
display_by_method(data, fp) display_by_method(data, fp)

tests/test-check-pytype.t

mercurial/manifest.py # [unsupported-operands], [wrong-arg-types] mercurial/manifest.py # [unsupported-operands], [wrong-arg-types]
mercurial/minirst.py # [unsupported-operands], [attribute-error] mercurial/minirst.py # [unsupported-operands], [attribute-error]
mercurial/patch.py # [wrong-arg-types] mercurial/patch.py # [wrong-arg-types]
mercurial/pure/osutil.py # [invalid-typevar], [not-callable] mercurial/pure/osutil.py # [invalid-typevar], [not-callable]
mercurial/pure/parsers.py # [attribute-error] mercurial/pure/parsers.py # [attribute-error]
mercurial/pycompat.py # bytes vs str issues mercurial/pycompat.py # bytes vs str issues
mercurial/repoview.py # [attribute-error] mercurial/repoview.py # [attribute-error]
mercurial/sslutil.py # [attribute-error] mercurial/sslutil.py # [attribute-error]
mercurial/statprof.py # bytes vs str on TextIO.write() [wrong-arg-types]
mercurial/testing/storage.py # tons of [attribute-error] mercurial/testing/storage.py # tons of [attribute-error]
mercurial/ui.py # [attribute-error], [wrong-arg-types] mercurial/ui.py # [attribute-error], [wrong-arg-types]
mercurial/unionrepo.py # ui, svfs, unfiltered [attribute-error] mercurial/unionrepo.py # ui, svfs, unfiltered [attribute-error]
mercurial/util.py # [attribute-error], [wrong-arg-count] mercurial/util.py # [attribute-error], [wrong-arg-count]
mercurial/utils/procutil.py # [attribute-error], [module-attr], [bad-return-type] mercurial/utils/procutil.py # [attribute-error], [module-attr], [bad-return-type]
mercurial/utils/memorytop.py # not 3.6 compatible mercurial/utils/memorytop.py # not 3.6 compatible
mercurial/win32.py # [not-callable] mercurial/win32.py # [not-callable]
mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error] mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error]
> -x mercurial/manifest.py \ > -x mercurial/manifest.py \
> -x mercurial/minirst.py \ > -x mercurial/minirst.py \
> -x mercurial/patch.py \ > -x mercurial/patch.py \
> -x mercurial/pure/osutil.py \ > -x mercurial/pure/osutil.py \
> -x mercurial/pure/parsers.py \ > -x mercurial/pure/parsers.py \
> -x mercurial/pycompat.py \ > -x mercurial/pycompat.py \
> -x mercurial/repoview.py \ > -x mercurial/repoview.py \
> -x mercurial/sslutil.py \ > -x mercurial/sslutil.py \
> -x mercurial/statprof.py \
> -x mercurial/testing/storage.py \ > -x mercurial/testing/storage.py \
> -x mercurial/thirdparty \ > -x mercurial/thirdparty \
> -x mercurial/ui.py \ > -x mercurial/ui.py \
> -x mercurial/unionrepo.py \ > -x mercurial/unionrepo.py \
> -x mercurial/utils/procutil.py \ > -x mercurial/utils/procutil.py \
> -x mercurial/utils/memorytop.py \ > -x mercurial/utils/memorytop.py \
> -x mercurial/win32.py \ > -x mercurial/win32.py \
> -x mercurial/wireprotoframing.py \ > -x mercurial/wireprotoframing.py \
> -x mercurial/wireprotoserver.py \ > -x mercurial/wireprotoserver.py \
> -x mercurial/wireprotov1peer.py \ > -x mercurial/wireprotov1peer.py \
> -x mercurial/wireprotov1server.py \ > -x mercurial/wireprotov1server.py \
> > $TESTTMP/pytype-output.txt || cat $TESTTMP/pytype-output.txt > > $TESTTMP/pytype-output.txt || cat $TESTTMP/pytype-output.txt
Only show the results on a failure, because the output on success is also Only show the results on a failure, because the output on success is also
voluminous and variable. voluminous and variable.