( )⚙ D11924 pytype: stop excluding webcommands.py

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11924

pytype: stop excluding webcommands.py
ClosedPublic

Authored by mharbison72 on Dec 14 2021, 4:11 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGea13dabbe168: pytype: stop excluding webcommands.py
Summary

I have no idea why, but asserting that each value added to emptydirs is not
None didn't fix this:

File "/mnt/c/Users/Matt/hg/mercurial/hgweb/webcommands.py", line 621, in dirlist:
    Function bytes.join was called with the wrong arguments [wrong-arg-types]
         Expected: (self, iterable: Iterable[bytes])
  Actually passed: (self, iterable: List[None])

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 14 2021, 4:11 PM
Alphare accepted this revision.Dec 15 2021, 5:35 AM
This revision is now accepted and ready to land.Dec 15 2021, 5:35 AM
mharbison72 added a commit: rHGea13dabbe168: pytype: stop excluding webcommands.py.Dec 17 2021, 6:11 AM
Closed by commit rHGea13dabbe168: pytype: stop excluding webcommands.py (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31518

mercurial/hgweb/webcommands.py

return web.sendtemplate(b'changeset', **webutil.changesetentry(web, ctx)) return web.sendtemplate(b'changeset', **webutil.changesetentry(web, ctx))
rev = webcommand(b'rev')(changeset) rev = webcommand(b'rev')(changeset)
def decodepath(path): def decodepath(path):
# type: (bytes) -> bytes
"""Hook for mapping a path in the repository to a path in the """Hook for mapping a path in the repository to a path in the
working copy. working copy.
Extensions (e.g., largefiles) can override this to remap files in Extensions (e.g., largefiles) can override this to remap files in
the virtual file system presented by the manifest command below.""" the virtual file system presented by the manifest command below."""
return path return path
if v: if v:
emptydirs.append(k) emptydirs.append(k)
h = v h = v
path = b"%s%s" % (abspath, d) path = b"%s%s" % (abspath, d)
yield { yield {
b"parity": next(parity), b"parity": next(parity),
b"path": path, b"path": path,
# pytype: disable=wrong-arg-types
b"emptydirs": b"/".join(emptydirs), b"emptydirs": b"/".join(emptydirs),
# pytype: enable=wrong-arg-types
b"basename": d, b"basename": d,
} }
return web.sendtemplate( return web.sendtemplate(
b'manifest', b'manifest',
symrev=symrev, symrev=symrev,
path=abspath, path=abspath,
up=webutil.up(abspath), up=webutil.up(abspath),

tests/test-check-pytype.t

mercurial/chgserver.py # [attribute-error] mercurial/chgserver.py # [attribute-error]
mercurial/context.py # many [attribute-error] mercurial/context.py # many [attribute-error]
mercurial/crecord.py # tons of [attribute-error], [module-attr] mercurial/crecord.py # tons of [attribute-error], [module-attr]
mercurial/debugcommands.py # [wrong-arg-types] mercurial/debugcommands.py # [wrong-arg-types]
mercurial/dispatch.py # initstdio: No attribute ... on TextIO [attribute-error] mercurial/dispatch.py # initstdio: No attribute ... on TextIO [attribute-error]
mercurial/exchange.py # [attribute-error] mercurial/exchange.py # [attribute-error]
mercurial/hgweb/hgweb_mod.py # [attribute-error], [name-error], [wrong-arg-types] mercurial/hgweb/hgweb_mod.py # [attribute-error], [name-error], [wrong-arg-types]
mercurial/hgweb/server.py # [attribute-error], [name-error], [module-attr] mercurial/hgweb/server.py # [attribute-error], [name-error], [module-attr]
mercurial/hgweb/webcommands.py # [missing-parameter]
mercurial/hgweb/wsgicgi.py # confused values in os.environ mercurial/hgweb/wsgicgi.py # confused values in os.environ
mercurial/httppeer.py # [attribute-error], [wrong-arg-types] mercurial/httppeer.py # [attribute-error], [wrong-arg-types]
mercurial/interfaces # No attribute 'capabilities' on peer [attribute-error] mercurial/interfaces # No attribute 'capabilities' on peer [attribute-error]
mercurial/keepalive.py # [attribute-error] mercurial/keepalive.py # [attribute-error]
mercurial/localrepo.py # [attribute-error] mercurial/localrepo.py # [attribute-error]
mercurial/manifest.py # [unsupported-operands], [wrong-arg-types] mercurial/manifest.py # [unsupported-operands], [wrong-arg-types]
mercurial/minirst.py # [unsupported-operands], [attribute-error] mercurial/minirst.py # [unsupported-operands], [attribute-error]
mercurial/pure/osutil.py # [invalid-typevar], [not-callable] mercurial/pure/osutil.py # [invalid-typevar], [not-callable]
> -x mercurial/chgserver.py \ > -x mercurial/chgserver.py \
> -x mercurial/context.py \ > -x mercurial/context.py \
> -x mercurial/crecord.py \ > -x mercurial/crecord.py \
> -x mercurial/debugcommands.py \ > -x mercurial/debugcommands.py \
> -x mercurial/dispatch.py \ > -x mercurial/dispatch.py \
> -x mercurial/exchange.py \ > -x mercurial/exchange.py \
> -x mercurial/hgweb/hgweb_mod.py \ > -x mercurial/hgweb/hgweb_mod.py \
> -x mercurial/hgweb/server.py \ > -x mercurial/hgweb/server.py \
> -x mercurial/hgweb/webcommands.py \
> -x mercurial/hgweb/wsgicgi.py \ > -x mercurial/hgweb/wsgicgi.py \
> -x mercurial/httppeer.py \ > -x mercurial/httppeer.py \
> -x mercurial/interfaces \ > -x mercurial/interfaces \
> -x mercurial/keepalive.py \ > -x mercurial/keepalive.py \
> -x mercurial/localrepo.py \ > -x mercurial/localrepo.py \
> -x mercurial/manifest.py \ > -x mercurial/manifest.py \
> -x mercurial/minirst.py \ > -x mercurial/minirst.py \
> -x mercurial/pure/osutil.py \ > -x mercurial/pure/osutil.py \