( )⚙ D11927 pytype: stop excluding procutil.py

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11927

pytype: stop excluding procutil.py
ClosedPublic

Authored by mharbison72 on Dec 15 2021, 3:47 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG333a2656e981: pytype: stop excluding procutil.py
Summary

This avoids these false warnings:

File "/mnt/c/Users/Matt/hg/mercurial/utils/procutil.py", line 78, in <module>:
    No attribute 'register' on Type[io.BufferedIOBase] [attribute-error]
File "/mnt/c/Users/Matt/hg/mercurial/utils/procutil.py", line 117, in <module>:
    No attribute 'register' on Type[io.IOBase] [attribute-error]
File "/mnt/c/Users/Matt/hg/mercurial/utils/procutil.py", line 770, in runbgcommandpy3:
    No attribute 'close' on int [attribute-error]
  In Union[IO[Union[bytes, str]], int]

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 15 2021, 3:47 PM
Alphare accepted this revision.Dec 17 2021, 5:58 AM
This revision is now accepted and ready to land.Dec 17 2021, 5:58 AM
mharbison72 added a commit: rHG333a2656e981: pytype: stop excluding procutil.py.Dec 17 2021, 6:11 AM
Closed by commit rHG333a2656e981: pytype: stop excluding procutil.py (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31520

mercurial/utils/procutil.py

def write(self, s): def write(self, s):
orig = self.orig orig = self.orig
res = orig.write(s) res = orig.write(s)
if s.endswith(b'\n'): if s.endswith(b'\n'):
orig.flush() orig.flush()
return res return res
# pytype: disable=attribute-error
io.BufferedIOBase.register(LineBufferedWrapper) io.BufferedIOBase.register(LineBufferedWrapper)
# pytype: enable=attribute-error
def make_line_buffered(stream): def make_line_buffered(stream):
if pycompat.ispy3 and not isinstance(stream, io.BufferedIOBase): if pycompat.ispy3 and not isinstance(stream, io.BufferedIOBase):
# On Python 3, buffered streams can be expected to subclass # On Python 3, buffered streams can be expected to subclass
# BufferedIOBase. This is definitively the case for the streams # BufferedIOBase. This is definitively the case for the streams
# initialized by the interpreter. For unbuffered streams, we don't need # initialized by the interpreter. For unbuffered streams, we don't need
# to emulate line buffering. # to emulate line buffering.
m = memoryview(s) m = memoryview(s)
total_to_write = len(s) total_to_write = len(s)
total_written = 0 total_written = 0
while total_written < total_to_write: while total_written < total_to_write:
total_written += write1(m[total_written:]) total_written += write1(m[total_written:])
return total_written return total_written
# pytype: disable=attribute-error
io.IOBase.register(WriteAllWrapper) io.IOBase.register(WriteAllWrapper)
# pytype: enable=attribute-error
def _make_write_all(stream): def _make_write_all(stream):
assert pycompat.ispy3 assert pycompat.ispy3
if isinstance(stream, WriteAllWrapper): if isinstance(stream, WriteAllWrapper):
return stream return stream
if isinstance(stream, io.BufferedIOBase): if isinstance(stream, io.BufferedIOBase):
# The io.BufferedIOBase.write() contract guarantees that all data is # The io.BufferedIOBase.write() contract guarantees that all data is
start_new_session=start_new_session, start_new_session=start_new_session,
) )
except Exception: except Exception:
if record_wait is not None: if record_wait is not None:
record_wait(255) record_wait(255)
raise raise
finally: finally:
if stdin_bytes is not None: if stdin_bytes is not None:
assert not isinstance(stdin, int)
stdin.close() stdin.close()
if not ensurestart: if not ensurestart:
# Even though we're not waiting on the child process, # Even though we're not waiting on the child process,
# we still must call waitpid() on it at some point so # we still must call waitpid() on it at some point so
# it's not a zombie/defunct. This is especially relevant for # it's not a zombie/defunct. This is especially relevant for
# chg since the parent process won't die anytime soon. # chg since the parent process won't die anytime soon.
# We use a thread to make the overhead tiny. # We use a thread to make the overhead tiny.
t = threading.Thread(target=lambda: p.wait) t = threading.Thread(target=lambda: p.wait)

tests/test-check-pytype.t

mercurial/pure/osutil.py # [invalid-typevar], [not-callable] mercurial/pure/osutil.py # [invalid-typevar], [not-callable]
mercurial/pure/parsers.py # [attribute-error] mercurial/pure/parsers.py # [attribute-error]
mercurial/pycompat.py # bytes vs str issues mercurial/pycompat.py # bytes vs str issues
mercurial/repoview.py # [attribute-error] mercurial/repoview.py # [attribute-error]
mercurial/sslutil.py # [attribute-error] mercurial/sslutil.py # [attribute-error]
mercurial/testing/storage.py # tons of [attribute-error] mercurial/testing/storage.py # tons of [attribute-error]
mercurial/ui.py # [attribute-error], [wrong-arg-types] mercurial/ui.py # [attribute-error], [wrong-arg-types]
mercurial/unionrepo.py # ui, svfs, unfiltered [attribute-error] mercurial/unionrepo.py # ui, svfs, unfiltered [attribute-error]
mercurial/utils/procutil.py # [attribute-error], [module-attr], [bad-return-type]
mercurial/utils/memorytop.py # not 3.6 compatible mercurial/utils/memorytop.py # not 3.6 compatible
mercurial/win32.py # [not-callable] mercurial/win32.py # [not-callable]
mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error] mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error]
mercurial/wireprotoserver.py # line 253, in _availableapis: No attribute '__iter__' on Callable[[Any, Any], Any] [attribute-error] mercurial/wireprotoserver.py # line 253, in _availableapis: No attribute '__iter__' on Callable[[Any, Any], Any] [attribute-error]
mercurial/wireprotov1peer.py # [attribute-error] mercurial/wireprotov1peer.py # [attribute-error]
mercurial/wireprotov1server.py # BUG?: BundleValueError handler accesses subclass's attrs mercurial/wireprotov1server.py # BUG?: BundleValueError handler accesses subclass's attrs
TODO: use --no-cache on test server? Caching the files locally helps during TODO: use --no-cache on test server? Caching the files locally helps during
> -x mercurial/pure/parsers.py \ > -x mercurial/pure/parsers.py \
> -x mercurial/pycompat.py \ > -x mercurial/pycompat.py \
> -x mercurial/repoview.py \ > -x mercurial/repoview.py \
> -x mercurial/sslutil.py \ > -x mercurial/sslutil.py \
> -x mercurial/testing/storage.py \ > -x mercurial/testing/storage.py \
> -x mercurial/thirdparty \ > -x mercurial/thirdparty \
> -x mercurial/ui.py \ > -x mercurial/ui.py \
> -x mercurial/unionrepo.py \ > -x mercurial/unionrepo.py \
> -x mercurial/utils/procutil.py \
> -x mercurial/utils/memorytop.py \ > -x mercurial/utils/memorytop.py \
> -x mercurial/win32.py \ > -x mercurial/win32.py \
> -x mercurial/wireprotoframing.py \ > -x mercurial/wireprotoframing.py \
> -x mercurial/wireprotoserver.py \ > -x mercurial/wireprotoserver.py \
> -x mercurial/wireprotov1peer.py \ > -x mercurial/wireprotov1peer.py \
> -x mercurial/wireprotov1server.py \ > -x mercurial/wireprotov1server.py \
> > $TESTTMP/pytype-output.txt || cat $TESTTMP/pytype-output.txt > > $TESTTMP/pytype-output.txt || cat $TESTTMP/pytype-output.txt
Only show the results on a failure, because the output on success is also Only show the results on a failure, because the output on success is also
voluminous and variable. voluminous and variable.