( )⚙ D12218 black: blacken with 22.1.0

This is an archive of the discontinued Mercurial Phabricator instance.

black: blacken with 22.1.0
Needs RevisionPublic

Authored by indygreg on Mar 1 2022, 7:17 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Summary

black 22.1.0 is the first non-beta release of black. I think it makes
sense for us to adopt this version of black.

This commit blackens the repo with version 22.1.0.

skip-blame: formatting only changes with black

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Mar 1 2022, 7:17 PM
Alphare added a subscriber: Alphare.Mar 2 2022, 5:11 AM

FYI I'm updating the heptapod CI to have this version of black as well. This might be a problem with stable since we'd need to use a different base CI image, but looking into pinning images was a long time coming anyway. I'll have a look at the rest of the patches in the meantime.

FYI I'm updating the heptapod CI to have this version of black as well. This might be a problem with stable since we'd need to use a different base CI image, but looking into pinning images was a long time coming anyway. I'll have a look at the rest of the patches in the meantime.

Oh, was that in the repo? Did I miss it?

Regarding stable, this series is small enough and it is early enough in the release cycle that we could probably apply this to stable with minimal effort. The sooner we do that the better, as there is bound to be churn on default soon.

indygreg updated this revision to Diff 32406.Mar 2 2022, 6:21 PM
Alphare requested changes to this revision.Mar 3 2022, 5:36 AM

FYI I'm updating the heptapod CI to have this version of black as well. This might be a problem with stable since we'd need to use a different base CI image, but looking into pinning images was a long time coming anyway. I'll have a look at the rest of the patches in the meantime.

Oh, was that in the repo? Did I miss it?

It's in a separate repo, I started the upgrade in response to this patch, so no worries.

Regarding stable, this series is small enough and it is early enough in the release cycle that we could probably apply this to stable with minimal effort. The sooner we do that the better, as there is bound to be churn on default soon.

I think this is part of a deeper issue with how we manage our images and backwards-compat in the Heptapod CI.

We need a small amount of work to make sure that kind of upgrade goes well in the future (as we're bound to upgrade Rust, Black, etc. more). This series and the one that depends on it will have to wait until early next week when this work is done so we can properly and cleanly address the root cause.

I'll still continue to review the patches so the potential back-and-forth needed can happen. I'm marking this as "changes requested" just as a flag for the issue above so as to not break the CI.

This revision now requires changes to proceed.Mar 3 2022, 5:36 AM