This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12328

help: remove pycompat.iteritems()
ClosedPublic

Authored by indygreg on Mar 3 2022, 4:21 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG428177ad70b0: help: remove pycompat.iteritems()

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 3 2022, 4:21 PM
Alphare accepted this revision.Mar 8 2022, 4:29 AM
This revision is now accepted and ready to land.Mar 8 2022, 4:29 AM
indygreg added a commit: rHG428177ad70b0: help: remove pycompat.iteritems().Mar 8 2022, 5:58 AM
Closed by commit rHG428177ad70b0: help: remove pycompat.iteritems() (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/help.py (6 lines)

Diff 32580

mercurial/help.py

doclines = docs.splitlines() doclines = docs.splitlines()
if doclines: if doclines:
summary = doclines[0] summary = doclines[0]
cmdname = cmdutil.parsealiases(cmd)[0] cmdname = cmdutil.parsealiases(cmd)[0]
if filtercmd(ui, cmdname, func, kw, docs): if filtercmd(ui, cmdname, func, kw, docs):
continue continue
results[b'commands'].append((cmdname, summary)) results[b'commands'].append((cmdname, summary))
for name, docs in itertools.chain( for name, docs in itertools.chain(
pycompat.iteritems(extensions.enabled(False)), extensions.enabled(False).items(),
pycompat.iteritems(extensions.disabled()), extensions.disabled().items(),
): ):
if not docs: if not docs:
continue continue
name = name.rpartition(b'.')[-1] name = name.rpartition(b'.')[-1]
if lowercontains(name) or lowercontains(docs): if lowercontains(name) or lowercontains(docs):
# extension docs are already translated # extension docs are already translated
results[b'extensions'].append((name, docs.splitlines()[0])) results[b'extensions'].append((name, docs.splitlines()[0]))
try: try:
mod = extensions.load(ui, name, b'') mod = extensions.load(ui, name, b'')
except ImportError: except ImportError:
# debug message would be printed in extensions.load() # debug message would be printed in extensions.load()
continue continue
for cmd, entry in pycompat.iteritems(getattr(mod, 'cmdtable', {})): for cmd, entry in getattr(mod, 'cmdtable', {}).items():
if kw in cmd or (len(entry) > 2 and lowercontains(entry[2])): if kw in cmd or (len(entry) > 2 and lowercontains(entry[2])):
cmdname = cmdutil.parsealiases(cmd)[0] cmdname = cmdutil.parsealiases(cmd)[0]
func = entry[0] func = entry[0]
cmddoc = pycompat.getdoc(func) cmddoc = pycompat.getdoc(func)
if cmddoc: if cmddoc:
cmddoc = gettext(cmddoc).splitlines()[0] cmddoc = gettext(cmddoc).splitlines()[0]
else: else:
cmddoc = _(b'(no help text available)') cmddoc = _(b'(no help text available)')