This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12351

check-code: remove ban on old-style classes
ClosedPublic

Authored by indygreg on Mar 3 2022, 10:31 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG55d132525155: check-code: remove ban on old-style classes
Summary

In Python 3, class foo: is equivalent to class foo(object):. So
we can allow the former form now.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 3 2022, 10:31 PM
Alphare accepted this revision.Mar 8 2022, 4:47 AM
This revision is now accepted and ready to land.Mar 8 2022, 4:47 AM
indygreg added a commit: rHG55d132525155: check-code: remove ban on old-style classes.Mar 8 2022, 6:06 AM
Closed by commit rHG55d132525155: check-code: remove ban on old-style classes (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-code.py (10 lines)
Mtests/test-contrib-check-code.t (6 lines)

Diff 32602

contrib/check-code.py

), ),
(r'[^\n]\Z', "no trailing newline"), (r'[^\n]\Z', "no trailing newline"),
(r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"), (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
( (
r'^\s*(if|while|def|class|except|try)\s[^[\n]*:\s*[^\\n]#\s]+', r'^\s*(if|while|def|class|except|try)\s[^[\n]*:\s*[^\\n]#\s]+',
"linebreak after :", "linebreak after :",
), ),
( (
r'class\s[^( \n]+:',
"old-style class, use class foo(object)",
r'#.*old-style',
),
(
r'class\s[^( \n]+\(\):',
"class foo() creates old style object, use class foo(object)",
r'#.*old-style',
),
(
r'\b(%s)\(' r'\b(%s)\('
% '|'.join(k for k in keyword.kwlist if k not in ('print', 'exec')), % '|'.join(k for k in keyword.kwlist if k not in ('print', 'exec')),
"Python keyword is not a function", "Python keyword is not a function",
), ),
# (r'class\s[A-Z][^\(]*\((?!Exception)', # (r'class\s[A-Z][^\(]*\((?!Exception)',
# "don't capitalize non-exception classes"), # "don't capitalize non-exception classes"),
# (r'in range\(', "use xrange"), # (r'in range\(', "use xrange"),
# (r'^\s*print\s+', "avoid using print in core and extensions"), # (r'^\s*print\s+', "avoid using print in core and extensions"),

tests/test-contrib-check-code.t

gratuitous whitespace in () or [] gratuitous whitespace in () or []
missing whitespace in expression missing whitespace in expression
./wrong.py:5: ./wrong.py:5:
> return 1 + \ > return 1 + \
Use () to wrap long lines in Python, not \ Use () to wrap long lines in Python, not \
./quote.py:5: ./quote.py:5:
> '"""', 42+1, """and > '"""', 42+1, """and
missing whitespace in expression missing whitespace in expression
./classstyle.py:4:
> class oldstyle_class:
old-style class, use class foo(object)
./classstyle.py:7:
> class empty():
class foo() creates old style object, use class foo(object)
[1] [1]
$ cat > python3-compat.py << NO_CHECK_EOF $ cat > python3-compat.py << NO_CHECK_EOF
> foo <> bar > foo <> bar
> reduce(lambda a, b: a + b, [1, 2, 3, 4]) > reduce(lambda a, b: a + b, [1, 2, 3, 4])
> dict(key=value) > dict(key=value)
> NO_CHECK_EOF > NO_CHECK_EOF
$ "$check_code" python3-compat.py $ "$check_code" python3-compat.py
python3-compat.py:1: python3-compat.py:1: