This is an archive of the discontinued Mercurial Phabricator instance.

rebase: pass wctx to rebasenode()

Authored by phillco on Oct 26 2017, 12:48 AM.


Diff Detail

rHG Mercurial
Lint Skipped
Unit Tests Skipped

Event Timeline

phillco updated this revision to Diff 4191.Dec 7 2017, 4:22 PM
phillco updated this revision to Diff 4210.Dec 7 2017, 4:44 PM
durin42 accepted this revision.Dec 7 2017, 4:59 PM
This revision is now accepted and ready to land.Dec 7 2017, 4:59 PM
dlax requested changes to this revision.Dec 8 2017, 4:29 AM
dlax added a subscriber: dlax.
dlax added inline comments.

Isn't it meant to be used in the function body? I see a wctx = repo[None] below, perhaps it should be dropped.

But this wouldn't work with a None default value as mentioned in the next patch.

This revision now requires changes to proceed.Dec 8 2017, 4:29 AM
phillco updated this revision to Diff 4260.Dec 8 2017, 3:09 PM
phillco added inline comments.Dec 8 2017, 3:10 PM

Yes, it's used in the next patch. But you're right that it's the only callsite, so I've made it non-optional.

durin42 accepted this revision.Dec 8 2017, 3:12 PM
This revision was automatically updated to reflect the committed changes.