This is an archive of the discontinued Mercurial Phabricator instance.

rebase: extract _assignworkingcopy
ClosedPublic

Authored by phillco on Dec 8 2017, 2:25 AM.

Details

Summary

Slightly cleaner, and makes it easier to hook this in an extension.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

phillco created this revision.Dec 8 2017, 2:25 AM
phillco updated this revision to Diff 4248.Dec 8 2017, 2:27 AM
dlax accepted this revision.Dec 8 2017, 4:45 AM
phillco updated this revision to Diff 4277.Dec 8 2017, 6:32 PM
This revision was automatically updated to reflect the committed changes.
krbullock added inline comments.
hgext/rebase.py
393

Rather than having this method spookily set self.wctx, why not make _assignworkingcopy _return_ the wctx (and rename it accordingly)?

phillco added inline comments.Dec 11 2017, 1:32 AM
hgext/rebase.py
393

Good point, I'll send a followup.