This is an archive of the discontinued Mercurial Phabricator instance.

githelp: don't reference 3rd party commands for `git show`
ClosedPublic

Authored by indygreg on Dec 19 2017, 12:36 AM.

Details

Summary

hg show is a Facebook-ism. Reference functionality in core.

The logic here isn't terrific. But it is better than nothing.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Dec 19 2017, 12:36 AM
durin42 accepted this revision.Dec 20 2017, 8:41 PM
This revision is now accepted and ready to land.Dec 20 2017, 8:41 PM
indygreg updated this revision to Diff 4597.Dec 22 2017, 8:39 PM
pulkit accepted this revision.Dec 28 2017, 3:54 PM
pulkit added a subscriber: pulkit.

I really like the extension added by the series. It will be nice one to have to help people who wanted to consider hg.

Added some inline comments which can be follow-ups if sounds good. There is also some inconsistency in output format which needs to be fixed.

How about having something like hg githelp concepts which can describe the basic difference between git and hg?

hgext/githelp.py
46

Maybe HEAD~ => .^ will be better.

163

We should add about how hg add is different from git add.

194

We should align this with other messages.

351

Maybe we should tell about hg update -C trick?

In D1729#30292, @pulkit wrote:

I really like the extension added by the series. It will be nice one to have to help people who wanted to consider hg.
Added some inline comments which can be follow-ups if sounds good. There is also some inconsistency in output format which needs to be fixed.
How about having something like hg githelp concepts which can describe the basic difference between git and hg?

I agree with these points! My immediate goal was getting the extension upstreamed near its current form. It still needs a bit of love.

With regards to the help section, I think hg help git should exist and should be a "Mercurial for Git Users" guide or something. It can inform users about the "githelp" extension.

krbullock requested changes to this revision.Jan 4 2018, 10:09 PM
krbullock added a subscriber: krbullock.
krbullock added inline comments.
hgext/githelp.py
882–883

I don't think tip is correct here, shouldn't this be .?

887

Same here, shouldn't use tip in newly-added docs or help if we can avoid it.

This revision now requires changes to proceed.Jan 4 2018, 10:09 PM
indygreg updated this revision to Diff 4817.Jan 14 2018, 2:20 PM
indygreg marked 2 inline comments as done.Jan 14 2018, 2:21 PM
durin42 accepted this revision.Jan 18 2018, 2:34 PM
This revision was automatically updated to reflect the committed changes.