Page MenuHomePhabricator

py3: use list() to get a list of items using dict.items()
ClosedPublic

Authored by pulkit on Dec 28 2017, 7:50 PM.

Details

Summary

dict.items() on Python 3 returns a generator over the values of the dictionary,
hence we can't delete elements while iterating over dict.items() in Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Dec 28 2017, 7:50 PM
durin42 accepted this revision.Jan 10 2018, 5:56 PM
This revision is now accepted and ready to land.Jan 10 2018, 5:56 PM
This revision was automatically updated to reflect the committed changes.