explicitly kill server processes
ClosedPublic

Authored by joerg.sonnenberger on Jan 12 2018, 11:13 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
indygreg accepted this revision.Jan 12 2018, 8:12 PM
This revision is now accepted and ready to land.Jan 12 2018, 8:12 PM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Jan 12 2018, 9:47 PM

Just for the record, explicit killdaemon isn't needed unless you want
to do something (e.g. checking server logs) after that. Daemons are
kill by the test runner.

In D1855#31400, @yuja wrote:

Just for the record, explicit killdaemon isn't needed unless you want
to do something (e.g. checking server logs) after that. Daemons are
kill by the test runner.

So what was the reason for this patch?

In D1855#31400, @yuja wrote:

Just for the record, explicit killdaemon isn't needed unless you want
to do something (e.g. checking server logs) after that. Daemons are
kill by the test runner.

So what was the reason for this patch?

I found bc7377160fa7 that adds this line and a comment saying "Explicitly kill daemons to let the test exit on Windows". Unfortunately, it doesn't explain any more than that. Is Joerg also running on Windows and maybe had the same problem (that the test doesn't exit, whatever that means)?

It was preparation for more tests here. Since I am moving them to a separate file now, I'm not really attached to it at all.