Details
Details
- Reviewers
indygreg - Group Reviewers
hg-reviewers - Commits
- rHGedf52be98978: test-pull-r: explicitly kill server processes
rHG5bda7bd29688: explicitly kill server processes
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Just for the record, explicit killdaemon isn't needed unless you want
to do something (e.g. checking server logs) after that. Daemons are
kill by the test runner.
Comment Actions
I found bc7377160fa7 that adds this line and a comment saying "Explicitly kill daemons to let the test exit on Windows". Unfortunately, it doesn't explain any more than that. Is Joerg also running on Windows and maybe had the same problem (that the test doesn't exit, whatever that means)?
Comment Actions
It was preparation for more tests here. Since I am moving them to a separate file now, I'm not really attached to it at all.