This is an archive of the discontinued Mercurial Phabricator instance.

Just for the record, explicit killdaemon isn't needed unless you want
to do something (e.g. checking server logs) after that. Daemons are
kill by the test runner.

In D1855#31400, @yuja wrote:

Just for the record, explicit killdaemon isn't needed unless you want
to do something (e.g. checking server logs) after that. Daemons are
kill by the test runner.

So what was the reason for this patch?

In D1855#31684, @martinvonz wrote:

In D1855#31400, @yuja wrote:

Just for the record, explicit killdaemon isn't needed unless you want
to do something (e.g. checking server logs) after that. Daemons are
kill by the test runner.

So what was the reason for this patch?

I found bc7377160fa7 that adds this line and a comment saying "Explicitly kill daemons to let the test exit on Windows". Unfortunately, it doesn't explain any more than that. Is Joerg also running on Windows and maybe had the same problem (that the test doesn't exit, whatever that means)?

It was preparation for more tests here. Since I am moving them to a separate file now, I'm not really attached to it at all.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-pull-r.t (1 line)

Diff 4809

tests/test-pull-r.t

	\|			\|
	o changeset: 0:bbd179dfa0a7			o changeset: 0:bbd179dfa0a7
	user: test			user: test
	date: Thu Jan 01 00:00:00 1970 +0000			date: Thu Jan 01 00:00:00 1970 +0000
	summary: add foo			summary: add foo


	$ cd ..			$ cd ..
				$ killdaemons.py

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	4809		Jan 12 2018, 11:12 AM	★	★
Diff 2	4814	rHG5bda7bd29688705e15168615c16a00564281f201	Jan 12 2018, 11:10 AM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

explicitly kill server processesClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4809

tests/test-pull-r.t

explicitly kill server processes
ClosedPublic

Revision Contents
Changeset List