This is an archive of the discontinued Mercurial Phabricator instance.

durin42 retitled this revision from mq: use pycompat.bytestr() instead of str() to encode statusentries for writing to mq: use bytes() instead of str() to encode statusentries for writing.Jan 18 2018, 11:13 AM

durin42 added a child revision: D1906: revlog: correct type in check to verify rawtext is immutable.

durin42 updated this revision to Diff 4910.

indygreg accepted this revision.Feb 1 2018, 3:40 PM

This revision is now accepted and ready to land.Feb 1 2018, 3:40 PM

Closed by commit rHG577a4d267e0f: mq: use bytes() instead of str() to encode statusentries for writing (authored by durin42). · Explain WhyFeb 1 2018, 3:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			hgext/mq.py (2 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	4893		Jan 18 2018, 8:39 AM	★	★
Diff 2	4910		Jan 18 2018, 11:13 AM	★	★
Diff 3	5073	rHG577a4d267e0f96d36fefba6974cd6798da6d3337	Jan 17 2018, 10:05 PM	★	★

Status	Author	Revision
Closed	durin42	D1905 strip: use in-place revset formatspec instead of %-formatting ourselves
Closed	durin42	D1908 python3: whitelist an additional 23 passing tests
Closed	durin42	D1907 tests: fix a missed b prefix in a test extension in test-strip.t
Closed	durin42	D1906 revlog: correct type in check to verify rawtext is immutable
Closed	durin42	D1903 mq: use bytes() instead of str() to encode statusentries for writing
Closed	durin42	D1902 mq: open status file et al in bytes mode
Closed	durin42	D1901 mq: fix up statusentry to be both repr()-able and bytes()-able
Closed	durin42	D1900 python3: whitelist another 7 passing tests
Closed	durin42	D1899 localrepo: pass transaction kwargs as strings, not bytes
Closed	durin42	D1898 localrepo: consistently use native str when __dict__ is involved
Closed	durin42	D1897 smartset: use native string when peeking in __dict__
Closed	durin42	D1896 obsolete: use native string when peeking in __dict__
Closed	durin42	D1895 lsprof: use native string when peeking in __dict__
Closed	durin42	D1894 dirstate: use native strings when peeking in __dict__
Closed	durin42	D1893 context: use native string when peeking in __dict__
Closed	durin42	D1892 bundlerepo: use native str when peeking in __dict__
Closed	durin42	D1891 transaction: fix hg version check when loading journal
Closed	durin42	D1890 branchmap: make error messages consistent between Python 2 and 3
Closed	durin42	D1889 tests: bytestring-ify all the adhoc extensions in test-strip.t
Closed	durin42	D1888 filemerge: fix regular expression pattern to be bytes
Closed	durin42	D1887 tags: explicitly grab list of dict keys
Closed	durin42	D1886 commands: replace map() with list comprehension
Closed	durin42	D1885 commands: rewrite legacy ternary operator hack using modern syntax
Closed	durin42	D1884 strip: use %d for known-int string interpolation
Closed	durin42	D1883 tests: get run-tests to reliably hand shellquote a string and not a bytes

Diff 4893

hgext/mq.py


	def savedirty(self):			def savedirty(self):
	def writelist(items, path):			def writelist(items, path):
	fp = self.opener(path, 'wb')			fp = self.opener(path, 'wb')
	for i in items:			for i in items:
	fp.write("%s\n" % i)			fp.write("%s\n" % i)
	fp.close()			fp.close()
	if self.applieddirty:			if self.applieddirty:
	writelist(map(str, self.applied), self.statuspath)			writelist(map(pycompat.bytestr, self.applied), self.statuspath)
	self.applieddirty = False			self.applieddirty = False
	if self.seriesdirty:			if self.seriesdirty:
	writelist(self.fullseries, self.seriespath)			writelist(self.fullseries, self.seriespath)
	self.seriesdirty = False			self.seriesdirty = False
	if self.guardsdirty:			if self.guardsdirty:
	writelist(self.activeguards, self.guardspath)			writelist(self.activeguards, self.guardspath)
	self.guardsdirty = False			self.guardsdirty = False
	if self.added:			if self.added:

This is an archive of the discontinued Mercurial Phabricator instance.

mq: use bytes() instead of str() to encode statusentries for writingClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4893

hgext/mq.py

mq: use bytes() instead of str() to encode statusentries for writing
ClosedPublic

Revision Contents
Changeset List