( )⚙ D1903 mq: use bytes() instead of str() to encode statusentries for writing

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1903

mq: use bytes() instead of str() to encode statusentries for writing
ClosedPublic

Authored by durin42 on Jan 18 2018, 8:39 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG522f868680ca: mq: use bytes() instead of str() to encode statusentries for writing
rHG577a4d267e0f: mq: use bytes() instead of str() to encode statusentries for writing
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 18 2018, 8:39 AM
yuja added a subscriber: yuja.Jan 18 2018, 9:04 AM

Perhaps it could be just bytes.

durin42 retitled this revision from mq: use pycompat.bytestr() instead of str() to encode statusentries for writing to mq: use bytes() instead of str() to encode statusentries for writing.Jan 18 2018, 11:13 AM
durin42 added a child revision: D1906: revlog: correct type in check to verify rawtext is immutable.
durin42 updated this revision to Diff 4910.
indygreg accepted this revision.Feb 1 2018, 3:40 PM
This revision is now accepted and ready to land.Feb 1 2018, 3:40 PM
Closed by commit rHG577a4d267e0f: mq: use bytes() instead of str() to encode statusentries for writing (authored by durin42). · Explain WhyFeb 1 2018, 3:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/mq.py (2 lines)

Diff 5073

hgext/mq.py

def savedirty(self): def savedirty(self):
def writelist(items, path): def writelist(items, path):
fp = self.opener(path, 'wb') fp = self.opener(path, 'wb')
for i in items: for i in items:
fp.write("%s\n" % i) fp.write("%s\n" % i)
fp.close() fp.close()
if self.applieddirty: if self.applieddirty:
writelist(map(str, self.applied), self.statuspath) writelist(map(bytes, self.applied), self.statuspath)
self.applieddirty = False self.applieddirty = False
if self.seriesdirty: if self.seriesdirty:
writelist(self.fullseries, self.seriespath) writelist(self.fullseries, self.seriespath)
self.seriesdirty = False self.seriesdirty = False
if self.guardsdirty: if self.guardsdirty:
writelist(self.activeguards, self.guardspath) writelist(self.activeguards, self.guardspath)
self.guardsdirty = False self.guardsdirty = False
if self.added: if self.added: