This is an archive of the discontinued Mercurial Phabricator instance.

strip: use in-place revset formatspec instead of %-formatting ourselves
ClosedPublic

Authored by durin42 on Jan 18 2018, 11:12 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Jan 18 2018, 11:12 AM
pulkit accepted this revision.Jan 20 2018, 5:21 AM
indygreg accepted this revision.Feb 1 2018, 3:29 PM
This revision is now accepted and ready to land.Feb 1 2018, 3:29 PM
This revision was automatically updated to reflect the committed changes.
martinvonz added inline comments.
hgext/strip.py
218

I would expect "%d" with a revision number (such as uctx.rev()). I saw that that's also what Yuya suggested on D1884. Fixing in flight.

martinvonz added inline comments.Feb 1 2018, 4:24 PM
hgext/strip.py
218

Oh, that's done in the next patch :P