This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2112

py3: replace file() with open() in test-convert-p4-filetypes.t
ClosedPublic

Authored by pulkit on Feb 11 2018, 7:39 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG42542adb8944: py3: replace file() with open() in test-convert-p4-filetypes.t
Summary

file() is not present in Python 3. While I was here, I added b'' prefix to make
sure we write things correctly in Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Feb 11 2018, 7:39 AM
Closed by commit rHG42542adb8944: py3: replace file() with open() in test-convert-p4-filetypes.t (authored by pulkit). · Explain WhyFeb 11 2018, 9:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-convert-p4-filetypes.t (2 lines)

Diff 5375

tests/test-convert-p4-filetypes.t

> ;; > ;;
> symlink*) > symlink*)
> echo "this is target $T" >target_$T2 > echo "this is target $T" >target_$T2
> ln -s target_$T file_$T2 > ln -s target_$T file_$T2
> p4 add target_$T2 > p4 add target_$T2
> p4 add -t $T file_$T2 > p4 add -t $T file_$T2
> ;; > ;;
> binary*) > binary*)
> $PYTHON -c "file('file_$T2', 'wb').write('this is $T')" > $PYTHON -c "open('file_$T2', 'wb').write(b'this is $T')"
> p4 add -t $T file_$T2 > p4 add -t $T file_$T2
> ;; > ;;
> *) > *)
> echo "this is $T" >file_$T2 > echo "this is $T" >file_$T2
> p4 add -t $T file_$T2 > p4 add -t $T file_$T2
> ;; > ;;
> esac > esac
> done > done