( )⚙ D2116 py3: replace file() with open() in test-tag.t

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2116

py3: replace file() with open() in test-tag.t
ClosedPublic

Authored by pulkit on Feb 11 2018, 7:40 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGeed40f0f4c6f: py3: replace file() with open() in test-tag.t
Summary

file() is not present in Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 11 2018, 7:40 AM
Closed by commit rHGeed40f0f4c6f: py3: replace file() with open() in test-tag.t (authored by pulkit). · Explain WhyFeb 11 2018, 9:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-tag.t (8 lines)

Diff 5405

tests/test-tag.t

$ hg -R test3 parents --style=compact $ hg -R test3 parents --style=compact
$ cd test $ cd test
Issue601: hg tag doesn't do the right thing if .hgtags or localtags Issue601: hg tag doesn't do the right thing if .hgtags or localtags
doesn't end with EOL doesn't end with EOL
$ $PYTHON << EOF $ $PYTHON << EOF
> f = file('.hg/localtags'); last = f.readlines()[-1][:-1]; f.close() > f = open('.hg/localtags'); last = f.readlines()[-1][:-1]; f.close()
> f = file('.hg/localtags', 'w'); f.write(last); f.close() > f = open('.hg/localtags', 'w'); f.write(last); f.close()
> EOF > EOF
$ cat .hg/localtags; echo $ cat .hg/localtags; echo
acb14030fe0a21b60322c440ad2d20cf7685a376 localblah acb14030fe0a21b60322c440ad2d20cf7685a376 localblah
$ hg tag -l localnewline $ hg tag -l localnewline
$ cat .hg/localtags; echo $ cat .hg/localtags; echo
acb14030fe0a21b60322c440ad2d20cf7685a376 localblah acb14030fe0a21b60322c440ad2d20cf7685a376 localblah
c2899151f4e76890c602a2597a650a72666681bf localnewline c2899151f4e76890c602a2597a650a72666681bf localnewline
$ $PYTHON << EOF $ $PYTHON << EOF
> f = file('.hgtags'); last = f.readlines()[-1][:-1]; f.close() > f = open('.hgtags'); last = f.readlines()[-1][:-1]; f.close()
> f = file('.hgtags', 'w'); f.write(last); f.close() > f = open('.hgtags', 'w'); f.write(last); f.close()
> EOF > EOF
$ hg ci -m'broken manual edit of .hgtags' $ hg ci -m'broken manual edit of .hgtags'
$ cat .hgtags; echo $ cat .hgtags; echo
acb14030fe0a21b60322c440ad2d20cf7685a376 foobar acb14030fe0a21b60322c440ad2d20cf7685a376 foobar
$ hg tag newline $ hg tag newline
hook: tag changes detected hook: tag changes detected
hook: +A a0eea09de1eeec777b46f2085260a373b2fbc293 newline hook: +A a0eea09de1eeec777b46f2085260a373b2fbc293 newline
$ cat .hgtags; echo $ cat .hgtags; echo