This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2122

py3: replace file() with open() in test-mactext.t
ClosedPublic

Authored by pulkit on Feb 11 2018, 7:41 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGadec6374a0b2: py3: replace file() with open() in test-mactext.t
Summary

file() is not present in Python 3.
This patch also adds a b'' prefix to make sure we write bytes in Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Feb 11 2018, 7:41 AM
Closed by commit rHGadec6374a0b2: py3: replace file() with open() in test-mactext.t (authored by pulkit). · Explain WhyFeb 11 2018, 9:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-mactext.t (6 lines)

Diff 5385

tests/test-mactext.t

$ cat > unix2mac.py <<EOF $ cat > unix2mac.py <<EOF
> import sys > import sys
> >
> for path in sys.argv[1:]: > for path in sys.argv[1:]:
> data = file(path, 'rb').read() > data = open(path, 'rb').read()
> data = data.replace('\n', '\r') > data = data.replace(b'\n', b'\r')
> file(path, 'wb').write(data) > open(path, 'wb').write(data)
> EOF > EOF
$ cat > print.py <<EOF $ cat > print.py <<EOF
> import sys > import sys
> print(sys.stdin.read().replace('\n', '<LF>').replace('\r', '<CR>').replace('\0', '<NUL>')) > print(sys.stdin.read().replace('\n', '<LF>').replace('\r', '<CR>').replace('\0', '<NUL>'))
> EOF > EOF
$ hg init $ hg init
$ echo '[hooks]' >> .hg/hgrc $ echo '[hooks]' >> .hg/hgrc
$ echo 'pretxncommit.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc $ echo 'pretxncommit.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc