This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2124

py3: replace file() with open() in test-import-git.t
ClosedPublic

Authored by pulkit on Feb 11 2018, 7:41 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG32695e525586: py3: replace file() with open() in test-import-git.t
Summary

file() is not present in Python 3.
This patch also adds a b'' prefix to make sure we write bytes in Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Feb 11 2018, 7:41 AM
Closed by commit rHG32695e525586: py3: replace file() with open() in test-import-git.t (authored by pulkit). · Explain WhyFeb 11 2018, 9:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-import-git.t (4 lines)

Diff 5387

tests/test-import-git.t

> rename from text2 > rename from text2
> rename to binary2 > rename to binary2
> index 78981922613b2afb6025042ff6bd878ac1994e85..10efcb362e9f3b3420fcfbfc0e37f3dc16e29757 > index 78981922613b2afb6025042ff6bd878ac1994e85..10efcb362e9f3b3420fcfbfc0e37f3dc16e29757
> GIT binary patch > GIT binary patch
> literal 5 > literal 5
> Mc$`b*O5$Pw00T?_*Z=?k > Mc$`b*O5$Pw00T?_*Z=?k
> >
> EOF > EOF
>>> fp = file('binary.diff', 'rb') >>> fp = open('binary.diff', 'rb')
>>> data = fp.read() >>> data = fp.read()
>>> fp.close() >>> fp.close()
>>> file('binary.diff', 'wb').write(data.replace('\n', '\r\n')) >>> open('binary.diff', 'wb').write(data.replace(b'\n', b'\r\n'))
$ rm binary2 $ rm binary2
$ hg import --no-commit binary.diff $ hg import --no-commit binary.diff
applying binary.diff applying binary.diff
$ cd .. $ cd ..
Consecutive import with renames (issue2459) Consecutive import with renames (issue2459)