This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2126

py3: replace file() with open() in test-import-bypass.t
ClosedPublic

Authored by pulkit on Feb 11 2018, 7:41 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGd667302b6ee1: py3: replace file() with open() in test-import-bypass.t
Summary

file() is not present in Python 3.
This patch also adds a b'' prefix to make sure we write bytes in Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Feb 11 2018, 7:41 AM
Closed by commit rHGd667302b6ee1: py3: replace file() with open() in test-import-bypass.t (authored by pulkit). · Explain WhyFeb 11 2018, 9:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-import-bypass.t (2 lines)

Diff 5389

tests/test-import-bypass.t

HG: changed a HG: changed a
abort: empty commit message abort: empty commit message
[255] [255]
Test patch.eol is handled Test patch.eol is handled
(this also tests that editor is not invoked for '--bypass', if the (this also tests that editor is not invoked for '--bypass', if the
commit message is explicitly specified, regardless of '--edit') commit message is explicitly specified, regardless of '--edit')
$ $PYTHON -c 'file("a", "wb").write("a\r\n")' $ $PYTHON -c 'open("a", "wb").write(b"a\r\n")'
$ hg ci -m makeacrlf $ hg ci -m makeacrlf
$ HGEDITOR=cat hg import -m 'should fail because of eol' --edit --bypass ../test.diff $ HGEDITOR=cat hg import -m 'should fail because of eol' --edit --bypass ../test.diff
applying ../test.diff applying ../test.diff
patching file a patching file a
Hunk #1 FAILED at 0 Hunk #1 FAILED at 0
abort: patch failed to apply abort: patch failed to apply
[255] [255]
$ hg --config patch.eol=auto import -d '0 0' -m 'test patch.eol' --bypass ../test.diff $ hg --config patch.eol=auto import -d '0 0' -m 'test patch.eol' --bypass ../test.diff