This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2127

py3: replace file() with open() in test-fileset.t
ClosedPublic

Authored by pulkit on Feb 11 2018, 7:41 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGf6a8a81f4f7b: py3: replace file() with open() in test-fileset.t
Summary

file() is not present in Python 3.
This patch also adds a b'' prefix to make sure we write bytes in Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Feb 11 2018, 7:41 AM
Closed by commit rHGf6a8a81f4f7b: py3: replace file() with open() in test-fileset.t (authored by pulkit). · Explain WhyFeb 11 2018, 9:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-fileset.t (6 lines)

Diff 5390

tests/test-fileset.t

a1 a1
a2 a2
b1 b1
b2 b2
c1 c1
Test files properties Test files properties
>>> file('bin', 'wb').write('\0a') >>> open('bin', 'wb').write(b'\0a')
$ fileset 'binary()' $ fileset 'binary()'
$ fileset 'binary() and unknown()' $ fileset 'binary() and unknown()'
bin bin
$ echo '^bin$' >> .hgignore $ echo '^bin$' >> .hgignore
$ fileset 'binary() and ignored()' $ fileset 'binary() and ignored()'
bin bin
$ hg add bin $ hg add bin
$ fileset 'binary()' $ fileset 'binary()'
#if no-windows #if no-windows
$ echo foo > con.xml $ echo foo > con.xml
$ fileset 'not portable()' $ fileset 'not portable()'
con.xml con.xml
$ hg --config ui.portablefilenames=ignore add con.xml $ hg --config ui.portablefilenames=ignore add con.xml
#endif #endif
>>> file('1k', 'wb').write(' '*1024) >>> open('1k', 'wb').write(b' '*1024)
>>> file('2k', 'wb').write(' '*2048) >>> open('2k', 'wb').write(b' '*2048)
$ hg add 1k 2k $ hg add 1k 2k
$ fileset 'size("bar")' $ fileset 'size("bar")'
hg: parse error: couldn't parse size: bar hg: parse error: couldn't parse size: bar
[255] [255]
$ fileset '(1k, 2k)' $ fileset '(1k, 2k)'
hg: parse error: can't use a list in this context hg: parse error: can't use a list in this context
(see hg help "filesets.x or y") (see hg help "filesets.x or y")
[255] [255]