( )⚙ D2129 py3: replace file() with open() in test-eol.t

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2129

py3: replace file() with open() in test-eol.t
ClosedPublic

Authored by pulkit on Feb 11 2018, 7:42 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGb85b0bbed6de: py3: replace file() with open() in test-eol.t
Summary

file() is not present in Python 3.
This patch also adds a b'' prefix to make sure we write bytes in Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 11 2018, 7:42 AM
Closed by commit rHGb85b0bbed6de: py3: replace file() with open() in test-eol.t (authored by pulkit). · Explain WhyFeb 11 2018, 9:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-eol.t (6 lines)

Diff 5418

tests/test-eol.t

> import os > import os
> import sys > import sys
> try: > try:
> import msvcrt > import msvcrt
> msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY) > msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY)
> msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY) > msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)
> except ImportError: > except ImportError:
> pass > pass
> (old, new) = sys.argv[1] == 'LF' and ('\n', '\r\n') or ('\r\n', '\n') > (old, new) = sys.argv[1] == 'LF' and (b'\n', b'\r\n') or (b'\r\n', b'\n')
> print("%% switching encoding from %r to %r" % (old, new)) > print("%% switching encoding from %r to %r" % (old, new))
> for path in sys.argv[2:]: > for path in sys.argv[2:]:
> data = file(path, 'rb').read() > data = open(path, 'rb').read()
> data = data.replace(old, new) > data = data.replace(old, new)
> file(path, 'wb').write(data) > open(path, 'wb').write(data)
> EOF > EOF
$ seteol () { $ seteol () {
> if [ $1 = "LF" ]; then > if [ $1 = "LF" ]; then
> EOL='\n' > EOL='\n'
> else > else
> EOL='\r\n' > EOL='\r\n'
> fi > fi