This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2189

narrowrevlog: add a TODO around remotefilelog moving to core
ClosedPublic

Authored by durin42 on Feb 12 2018, 3:03 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG66b4ffe90676: narrowrevlog: add a TODO around remotefilelog moving to core
Summary

We should clean this up considerably when remotefilelog lands, which
we expect to try and accomplish in the near-ish future.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 12 2018, 3:03 PM
durin42 updated this revision to Diff 5519.Feb 12 2018, 3:24 PM
indygreg accepted this revision.Feb 12 2018, 5:54 PM
This revision is now accepted and ready to land.Feb 12 2018, 5:54 PM
Closed by commit rHG66b4ffe90676: narrowrevlog: add a TODO around remotefilelog moving to core (authored by durin42). · Explain WhyFeb 12 2018, 6:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/narrow/narrowrevlog.py (4 lines)

Diff 5559

hgext/narrow/narrowrevlog.py

return m return m
def size(self, rev): def size(self, rev):
# We take advantage of the fact that remotefilelog # We take advantage of the fact that remotefilelog
# lacks a node() method to just skip the # lacks a node() method to just skip the
# rename-checking logic when on remotefilelog. This # rename-checking logic when on remotefilelog. This
# might be incorrect on other non-revlog-based storage # might be incorrect on other non-revlog-based storage
# engines, but for now this seems to be fine. # engines, but for now this seems to be fine.
#
# TODO: when remotefilelog is in core, improve this to
# explicitly look for remotefilelog instead of cheating
# with a hasattr check.
if util.safehasattr(self, 'node'): if util.safehasattr(self, 'node'):
node = self.node(rev) node = self.node(rev)
# Because renamed() is overridden above to # Because renamed() is overridden above to
# sometimes return None even if there is metadata # sometimes return None even if there is metadata
# in the revlog, size can be incorrect for # in the revlog, size can be incorrect for
# copies/renames, so we need to make sure we call # copies/renames, so we need to make sure we call
# the super class's implementation of renamed() # the super class's implementation of renamed()
# for the purpose of size calculation. # for the purpose of size calculation.