This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2193

narrowwirepeer: rename expandnarrow capability to exp-expandnarrow
ClosedPublic

Authored by durin42 on Feb 12 2018, 3:03 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG22ed16caa596: narrowwirepeer: rename expandnarrow capability to exp-expandnarrow
Summary

The expandnarrow functionality lets a client have a shorthand (for
Google it's a reference to a checked-in file) for a set of includes
and excludes. For testing we should probably implement a simple
version of that functionality here. For now, rename the capability so
we don't burn the good name in the future if we need to change
behavior.

It's plausible that this functionality should be dropped from the
narrowhg we ship long-term, but I'm dubious as it seems pretty likely
other organizations will want similar shorthands for commonly-used
subsets of their trees.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 12 2018, 3:03 PM
indygreg accepted this revision.Feb 12 2018, 5:56 PM
This revision is now accepted and ready to land.Feb 12 2018, 5:56 PM
Closed by commit rHG22ed16caa596: narrowwirepeer: rename expandnarrow capability to exp-expandnarrow (authored by durin42). · Explain WhyFeb 12 2018, 6:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/narrow/narrowwirepeer.py (2 lines)

Diff 5563

hgext/narrow/narrowwirepeer.py

def uisetup(): def uisetup():
def peersetup(ui, peer): def peersetup(ui, peer):
# We must set up the expansion before reposetup below, since it's used # We must set up the expansion before reposetup below, since it's used
# at clone time before we have a repo. # at clone time before we have a repo.
class expandingpeer(peer.__class__): class expandingpeer(peer.__class__):
def expandnarrow(self, narrow_include, narrow_exclude, nodes): def expandnarrow(self, narrow_include, narrow_exclude, nodes):
ui.status(_("expanding narrowspec\n")) ui.status(_("expanding narrowspec\n"))
if not self.capable('expandnarrow'): if not self.capable('exp-expandnarrow'):
raise error.Abort( raise error.Abort(
'peer does not support expanding narrowspecs') 'peer does not support expanding narrowspecs')
hex_nodes = (node.hex(n) for n in nodes) hex_nodes = (node.hex(n) for n in nodes)
new_narrowspec = self._call( new_narrowspec = self._call(
'expandnarrow', 'expandnarrow',
includepats=','.join(narrow_include), includepats=','.join(narrow_include),
excludepats=','.join(narrow_exclude), excludepats=','.join(narrow_exclude),