Page MenuHomePhabricator

narrow: move from ELLIPSIS_NODE_FLAG to revlog.REVIDX_ELLIPSIS
ClosedPublic

Authored by durin42 on Feb 2 2018, 10:53 AM.

Details

Summary

We should have been using this value all along. Sigh.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 2 2018, 10:53 AM
indygreg added inline comments.Feb 2 2018, 2:03 PM
hgext/narrow/narrowrevlog.py
25

Does this also need to move to core? What happens when core encounters this revision flag without a registered flag processor (this should never happen if repo requirements are done properly though).

martinvonz added inline comments.
mercurial/revlog.py
60 ↗(On Diff #5158)

See comment on earlier patch that the flag is already defined here (line 71), unless I'm missing something

durin42 updated this revision to Diff 5499.Feb 12 2018, 3:03 PM
durin42 edited the summary of this revision. (Show Details)Feb 12 2018, 3:23 PM
durin42 retitled this revision from revlog: move ELLIPSIS_NODE_FLAG to core from narrowrevlog to narrow: move from ELLIPSIS_NODE_FLAG to revlog.REVIDX_ELLIPSIS.
durin42 updated this revision to Diff 5513.
indygreg accepted this revision.Feb 12 2018, 6:03 PM
This revision is now accepted and ready to land.Feb 12 2018, 6:03 PM
This revision was automatically updated to reflect the committed changes.