Page MenuHomePhabricator

narrow: this code should assume REVIDX_FLAGS_ORDER exists
ClosedPublic

Authored by durin42 on Feb 1 2018, 6:00 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 1 2018, 6:00 PM
martinvonz requested changes to this revision.Feb 2 2018, 1:41 PM
martinvonz added a subscriber: martinvonz.
martinvonz added inline comments.
hgext/narrow/narrowrevlog.py
16–20

looks like you can instead drop all of this since we have now (since 08b34c3a6f74) defined the flag in revlog.py (and just use revlog.REVIDX_ELLIPSIS instead below)

This revision now requires changes to proceed.Feb 2 2018, 1:41 PM
durin42 added inline comments.Feb 12 2018, 3:21 PM
hgext/narrow/narrowrevlog.py
16–20

I'll do that in D2008.

indygreg accepted this revision.Feb 12 2018, 6:02 PM
This revision was automatically updated to reflect the committed changes.