( )⚙ D1977 narrow: this code should assume REVIDX_FLAGS_ORDER exists

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1977

narrow: this code should assume REVIDX_FLAGS_ORDER exists
ClosedPublic

Authored by durin42 on Feb 1 2018, 6:00 PM.

Details

Reviewers
martinvonz
indygreg
Group Reviewers
hg-reviewers
Commits
rHGadc8e1fe2f46: narrow: this code should assume REVIDX_FLAGS_ORDER exists
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 1 2018, 6:00 PM
martinvonz requested changes to this revision.Feb 2 2018, 1:41 PM
martinvonz added a subscriber: martinvonz.
martinvonz added inline comments.
hgext/narrow/narrowrevlog.py
16–20

looks like you can instead drop all of this since we have now (since 08b34c3a6f74) defined the flag in revlog.py (and just use revlog.REVIDX_ELLIPSIS instead below)

This revision now requires changes to proceed.Feb 2 2018, 1:41 PM
durin42 added inline comments.Feb 12 2018, 3:21 PM
hgext/narrow/narrowrevlog.py
16–20

I'll do that in D2008.

indygreg accepted this revision.Feb 12 2018, 6:02 PM
Closed by commit rHGadc8e1fe2f46: narrow: this code should assume REVIDX_FLAGS_ORDER exists (authored by durin42). · Explain WhyFeb 12 2018, 6:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/narrow/narrowrevlog.py (5 lines)

Diff 5544

hgext/narrow/narrowrevlog.py

# narrowrevlog.py - revlog storing irrelevant nodes as "ellipsis" nodes # narrowrevlog.py - revlog storing irrelevant nodes as "ellipsis" nodes
# #
# Copyright 2017 Google, Inc. # Copyright 2017 Google, Inc.
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
from __future__ import absolute_import from __future__ import absolute_import
from mercurial import ( from mercurial import (
manifest, manifest,
revlog, revlog,
util, util,
) )
ELLIPSIS_NODE_FLAG = 1 << 14 ELLIPSIS_NODE_FLAG = 1 << 14
revlog.REVIDX_KNOWN_FLAGS |= ELLIPSIS_NODE_FLAG revlog.REVIDX_KNOWN_FLAGS |= ELLIPSIS_NODE_FLAG
if (util.safehasattr(revlog, 'REVIDX_FLAGS_ORDER') and if ELLIPSIS_NODE_FLAG not in revlog.REVIDX_FLAGS_ORDER:
ELLIPSIS_NODE_FLAG not in revlog.REVIDX_FLAGS_ORDER):
revlog.REVIDX_FLAGS_ORDER.append(ELLIPSIS_NODE_FLAG) revlog.REVIDX_FLAGS_ORDER.append(ELLIPSIS_NODE_FLAG)
martinvonzUnsubmitted
Not Done

looks like you can instead drop all of this since we have now (since 08b34c3a6f74) defined the flag in revlog.py (and just use revlog.REVIDX_ELLIPSIS instead below)

martinvonz: looks like you can instead drop all of this since we have now (since 08b34c3a6f74) defined the…
durin42AuthorUnsubmitted
Not Done

I'll do that in D2008.

durin42: I'll do that in D2008.
def readtransform(self, text): def readtransform(self, text):
return text, False return text, False
def writetransform(self, text): def writetransform(self, text):
return text, False return text, False
def rawtransform(self, text): def rawtransform(self, text):