( )⚙ D2261 py3: use pycompat.bytestr to convert str to bytes

This is an archive of the discontinued Mercurial Phabricator instance.

py3: use pycompat.bytestr to convert str to bytes
ClosedPublic

Authored by pulkit on Feb 14 2018, 6:25 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Feb 14 2018, 6:25 AM
yuja requested changes to this revision.Feb 14 2018, 8:17 AM
yuja added a subscriber: yuja.

Here '%r' % pycompat.bytestr(user) is preferred since repr(user) would
leave b'' prefix in error message.

This revision now requires changes to proceed.Feb 14 2018, 8:17 AM
pulkit updated this revision to Diff 5726.Feb 14 2018, 11:26 AM
yuja accepted this revision.Feb 15 2018, 7:17 AM
This revision is now accepted and ready to land.Feb 15 2018, 7:17 AM
This revision was automatically updated to reflect the committed changes.