( )⚙ D2467 sshpeer: support not reading and forwarding stderr

This is an archive of the discontinued Mercurial Phabricator instance.

sshpeer: support not reading and forwarding stderr
ClosedPublic

Authored by indygreg on Feb 26 2018, 4:16 PM.

Details

Summary

The "doublepipe" primitive as used by sshpeer will automatically read
from stderr and forward output to the local ui.

This poses problems for deterministic testing because reads may not
be consistent. For example, the server may not be done sending all
output to stderr and the client will perform different numbers of
read operations or will read from stderr and stdout at different times.

To make tests deterministic, we'll need to disable the "doublepipe"
primitive and perform stderr I/O explicitly. We add an argument to the
sshpeer constructor to disable the use of the doublepipe.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Feb 26 2018, 4:16 PM
indygreg updated this revision to Diff 6255.Mar 1 2018, 11:30 AM
durin42 accepted this revision.Mar 1 2018, 4:39 PM
This revision is now accepted and ready to land.Mar 1 2018, 4:39 PM
This revision was automatically updated to reflect the committed changes.