( )⚙ D2673 archival: use py3 friendly replacements for chr() and long()

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2673

archival: use py3 friendly replacements for chr() and long()
ClosedPublic

Authored by durin42 on Mar 4 2018, 4:13 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGf14ba6eb2b5a: archival: use py3 friendly replacements for chr() and long()
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Mar 4 2018, 4:13 PM
pulkit accepted this revision.Mar 4 2018, 4:33 PM
Closed by commit rHGf14ba6eb2b5a: archival: use py3 friendly replacements for chr() and long() (authored by durin42). · Explain WhyMar 4 2018, 4:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/python3-whitelist (3 lines)
Mmercurial/archival.py (4 lines)

Diff 6616

contrib/python3-whitelist

test-issue522.t test-issue522.t
test-issue586.t test-issue586.t
test-issue612.t test-issue612.t
test-issue619.t test-issue619.t
test-issue672.t test-issue672.t
test-issue842.t test-issue842.t
test-journal-exists.t test-journal-exists.t
test-largefiles-cache.t test-largefiles-cache.t
test-largefiles-misc.t
test-largefiles-small-disk.t test-largefiles-small-disk.t
test-locate.t test-locate.t
test-lock-badness.t test-lock-badness.t
test-log.t test-log.t
test-logexchange.t test-logexchange.t
test-lrucachedict.py test-lrucachedict.py
test-mactext.t test-mactext.t
test-manifest-merging.t test-manifest-merging.t
test-mq-qqueue.t test-mq-qqueue.t
test-mq-qrefresh-replace-log-message.t test-mq-qrefresh-replace-log-message.t
test-mq-qrefresh.t test-mq-qrefresh.t
test-mq-qrename.t test-mq-qrename.t
test-mq-qsave.t test-mq-qsave.t
test-mq-safety.t test-mq-safety.t
test-mq-symlinks.t test-mq-symlinks.t
test-mv-cp-st-diff.t test-mv-cp-st-diff.t
test-narrow-archive.t
test-narrow-clone-no-ellipsis.t test-narrow-clone-no-ellipsis.t
test-narrow-clone-nonlinear.t test-narrow-clone-nonlinear.t
test-narrow-clone.t test-narrow-clone.t
test-narrow-commit.t test-narrow-commit.t
test-narrow-copies.t test-narrow-copies.t
test-narrow-debugcommands.t test-narrow-debugcommands.t
test-narrow-debugrebuilddirstate.t test-narrow-debugrebuilddirstate.t
test-narrow-exchange-merges.t test-narrow-exchange-merges.t
test-sparse-verbose-json.t test-sparse-verbose-json.t
test-ssh-clone-r.t test-ssh-clone-r.t
test-ssh-proto.t test-ssh-proto.t
test-sshserver.py test-sshserver.py
test-status-rev.t test-status-rev.t
test-status-terse.t test-status-terse.t
test-strip-cross.t test-strip-cross.t
test-strip.t test-strip.t
test-subrepo-deep-nested-change.t
test-subrepo.t test-subrepo.t
test-symlinks.t test-symlinks.t
test-treemanifest.t test-treemanifest.t
test-unamend.t test-unamend.t
test-uncommit.t test-uncommit.t
test-unified-test.t test-unified-test.t
test-unrelated-pull.t test-unrelated-pull.t
test-up-local-change.t test-up-local-change.t

mercurial/archival.py

self.fileobj.write('\037\213') # magic header self.fileobj.write('\037\213') # magic header
self.fileobj.write('\010') # compression method self.fileobj.write('\010') # compression method
fname = self.name fname = self.name
if fname and fname.endswith('.gz'): if fname and fname.endswith('.gz'):
fname = fname[:-3] fname = fname[:-3]
flags = 0 flags = 0
if fname: if fname:
flags = gzip.FNAME flags = gzip.FNAME
self.fileobj.write(chr(flags)) self.fileobj.write(pycompat.bytechr(flags))
gzip.write32u(self.fileobj, long(self.timestamp)) gzip.write32u(self.fileobj, int(self.timestamp))
self.fileobj.write('\002') self.fileobj.write('\002')
self.fileobj.write('\377') self.fileobj.write('\377')
if fname: if fname:
self.fileobj.write(fname + '\000') self.fileobj.write(fname + '\000')
def __init__(self, dest, mtime, kind=''): def __init__(self, dest, mtime, kind=''):
self.mtime = mtime self.mtime = mtime
self.fileobj = None self.fileobj = None