This is an archive of the discontinued Mercurial Phabricator instance.

rebase: remove unused default argument values from conclude[memory]node()
ClosedPublic

Authored by martinvonz on Mar 21 2018, 2:10 PM.

Details

Summary

It's only "commitmsg" that we don't always pass.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 21 2018, 2:10 PM
indygreg accepted this revision.Mar 21 2018, 7:12 PM
indygreg added a subscriber: indygreg.

I wonder if it is worth creating a dedicated type to represent the fields in a commit. We have a handful of these functions around the code base where you need to pass around a bunch of values as a unit. But that would be follow-up fodder.

This revision is now accepted and ready to land.Mar 21 2018, 7:12 PM
This revision was automatically updated to reflect the committed changes.