This is an archive of the discontinued Mercurial Phabricator instance.

rebase: extract common _concludenode()
ClosedPublic

Authored by martinvonz on Mar 21 2018, 2:10 PM.

Details

Summary

_rebasenode() and _finishrebase() had a lot of code in common. This
commit extracts some of that. This means we will also have a single
caller of concludenode() and concludememorynode(), which gives us a
place to put code that is common between those two functions (which is
quite a bit).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 21 2018, 2:10 PM
indygreg accepted this revision.Mar 21 2018, 7:31 PM
indygreg added a subscriber: indygreg.

Nice.

This revision is now accepted and ready to land.Mar 21 2018, 7:31 PM
This revision was automatically updated to reflect the committed changes.