Page MenuHomePhabricator

rebase: rename conclude[memory]node() to commit[memory]node()
ClosedPublic

Authored by martinvonz on Mar 21 2018, 2:10 PM.

Details

Summary

The functions do little more than commit at this point.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 21 2018, 2:10 PM
indygreg accepted this revision.Mar 21 2018, 7:47 PM
indygreg added a subscriber: indygreg.

Very nice cleanup!

This revision is now accepted and ready to land.Mar 21 2018, 7:47 PM
This revision was automatically updated to reflect the committed changes.

What _is_ the difference between "conclude" and "commit"?

What _is_ the difference between "conclude" and "commit"?

I had assumed it was called "conclude" because it did more than commit (the stuff that's now in _concludecommit()). There's obviously no agreed-upon definition of the terms in a hg context, so I guess we'll have to interpret it as we like.