This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3041

changegroup: remove "revlog" from error message
ClosedPublic

Authored by indygreg on Apr 3 2018, 1:53 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG5859800edfc5: changegroup: remove "revlog" from error message
Summary

The previous message leaked an implementation detail.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 3 2018, 1:53 PM
durin42 accepted this revision.Apr 4 2018, 2:10 PM
This revision is now accepted and ready to land.Apr 4 2018, 2:10 PM
Closed by commit rHG5859800edfc5: changegroup: remove "revlog" from error message (authored by indygreg). · Explain WhyApr 4 2018, 3:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/changegroup.py (3 lines)

Diff 7640

mercurial/changegroup.py

msgbundling = _('bundling') msgbundling = _('bundling')
total = len(changedfiles) total = len(changedfiles)
# for progress output # for progress output
msgfiles = _('files') msgfiles = _('files')
for i, fname in enumerate(sorted(changedfiles)): for i, fname in enumerate(sorted(changedfiles)):
filerevlog = repo.file(fname) filerevlog = repo.file(fname)
if not filerevlog: if not filerevlog:
raise error.Abort(_("empty or missing revlog for %s") % fname) raise error.Abort(_("empty or missing file data for %s") %
fname)
linkrevnodes = linknodes(filerevlog, fname) linkrevnodes = linknodes(filerevlog, fname)
# Lookup for filenodes, we collected the linkrev nodes above in the # Lookup for filenodes, we collected the linkrev nodes above in the
# fastpath case and with lookupmf in the slowpath case. # fastpath case and with lookupmf in the slowpath case.
def lookupfilelog(x): def lookupfilelog(x):
return linkrevnodes[x] return linkrevnodes[x]
filenodes = self.prune(filerevlog, linkrevnodes, commonrevs) filenodes = self.prune(filerevlog, linkrevnodes, commonrevs)