Page MenuHomePhabricator

narrow: pass node into revlog.revision()

Authored by indygreg on Apr 3 2018, 1:53 PM.



This is one of the few (possibly only) places where we pass an int in
for filelogs. Other revlogs (notably changelog) are very heavy on int
usage. But filelogs are surprisingly node centric. I'd like to
formalize the interface around the use of nodes (at least for
filelogs). So let's switch to a node.

We can't inline revlog.node() because of a check-code rule. I think
that rule is suspect. But it may be for performance reasons with
changelog code. I'd rather not touch it at this time.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 3 2018, 1:53 PM
durin42 accepted this revision.Apr 4 2018, 2:11 PM

Yes please!

This revision is now accepted and ready to land.Apr 4 2018, 2:11 PM
This revision was automatically updated to reflect the committed changes.