This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3056

tests: disable test-revlog-v2 when using simple store
ClosedPublic

Authored by indygreg on Apr 3 2018, 9:55 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGb09a25d74592: tests: disable test-revlog-v2 when using simple store
Summary

Because the simple store has nothing to do with revlogs.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 3 2018, 9:55 PM
durin42 accepted this revision.Apr 4 2018, 2:11 PM
This revision is now accepted and ready to land.Apr 4 2018, 2:11 PM
durin42 added a comment.Apr 4 2018, 2:12 PM

Though I do wonder if this should be a positive check, that is, "require it's on revlogs" rather than "require it's not on the simple store"?

indygreg added a comment.Apr 4 2018, 2:31 PM
In D3056#49554, @durin42 wrote:

Though I do wonder if this should be a positive check, that is, "require it's on revlogs" rather than "require it's not on the simple store"?

Yes, it should. Will re-submit.

indygreg updated this revision to Diff 7632.Apr 4 2018, 2:31 PM
durin42 accepted this revision.Apr 4 2018, 3:01 PM
Closed by commit rHGb09a25d74592: tests: disable test-revlog-v2 when using simple store (authored by indygreg). · Explain WhyApr 4 2018, 5:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-revlog-v2.t (2 lines)

Diff 7647

tests/test-revlog-v2.t

#require reporevlogstore
A repo with unknown revlogv2 requirement string cannot be opened A repo with unknown revlogv2 requirement string cannot be opened
$ hg init invalidreq $ hg init invalidreq
$ cd invalidreq $ cd invalidreq
$ echo exp-revlogv2.unknown >> .hg/requires $ echo exp-revlogv2.unknown >> .hg/requires
$ hg log $ hg log
abort: repository requires features unknown to this Mercurial: exp-revlogv2.unknown! abort: repository requires features unknown to this Mercurial: exp-revlogv2.unknown!
(see https://mercurial-scm.org/wiki/MissingRequirement for more information) (see https://mercurial-scm.org/wiki/MissingRequirement for more information)