( )⚙ D3079 localrepo: drop "remote" argument from lookupbranch() (API)

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3079

localrepo: drop "remote" argument from lookupbranch() (API)
ClosedPublic

Authored by martinvonz on Apr 4 2018, 6:53 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGfdd22bf6398f: localrepo: drop "remote" argument from lookupbranch() (API)
Summary

According to hg grep --all lookupbranch, the "remote" argument has
never been used ever since it was introduced in ca739acf1a98
(commands: add more robust support for 'hg log -b' (issue2078),
2010-04-12).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Apr 4 2018, 6:53 PM
indygreg accepted this revision.Apr 4 2018, 8:42 PM
This revision is now accepted and ready to land.Apr 4 2018, 8:42 PM
Closed by commit rHGfdd22bf6398f: localrepo: drop "remote" argument from lookupbranch() (API) (authored by martinvonz). · Explain WhyApr 4 2018, 8:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (8 lines)
Mmercurial/repository.py (2 lines)

Diff 7653

mercurial/localrepo.py

if not ignoremissing: if not ignoremissing:
raise error.RepoLookupError(_("unknown branch '%s'") % branch) raise error.RepoLookupError(_("unknown branch '%s'") % branch)
else: else:
pass pass
def lookup(self, key): def lookup(self, key):
return scmutil.revsymbol(self, key).node() return scmutil.revsymbol(self, key).node()
def lookupbranch(self, key, remote=None): def lookupbranch(self, key):
repo = remote or self if key in self.branchmap():
if key in repo.branchmap():
return key return key
repo = (remote and remote.local()) and remote or self return self[key].branch()
return repo[key].branch()
def known(self, nodes): def known(self, nodes):
cl = self.changelog cl = self.changelog
nm = cl.nodemap nm = cl.nodemap
filtered = cl.filteredrevs filtered = cl.filteredrevs
result = [] result = []
for n in nodes: for n in nodes:
r = nm.get(n) r = nm.get(n)

mercurial/repository.py

pass pass
def branchtip(branchtip, ignoremissing=False): def branchtip(branchtip, ignoremissing=False):
"""Return the tip node for a given branch.""" """Return the tip node for a given branch."""
def lookup(key): def lookup(key):
"""Resolve the node for a revision.""" """Resolve the node for a revision."""
def lookupbranch(key, remote=None): def lookupbranch(key):
"""Look up the branch name of the given revision or branch name.""" """Look up the branch name of the given revision or branch name."""
def known(nodes): def known(nodes):
"""Determine whether a series of nodes is known. """Determine whether a series of nodes is known.
Returns a list of bools. Returns a list of bools.
""" """