This is an archive of the discontinued Mercurial Phabricator instance.

wireproto: use repo.lookup() for lookup command
ClosedPublic

Authored by martinvonz on Apr 4 2018, 6:53 PM.

Details

Summary

I'm trying to reduce use of repo[<string>] and this seems like an
obvious place to use repo.lookup().

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Apr 4 2018, 6:53 PM
indygreg accepted this revision.Apr 4 2018, 8:46 PM
indygreg added a subscriber: indygreg.

The fact that this wasn't using lookup() is mind numbing. What the wire protocol command handlers should be doing in many cases is calling repo.peer().<command>(). Now you can see how bad the wire protocol code is :/

This revision is now accepted and ready to land.Apr 4 2018, 8:46 PM
This revision was automatically updated to reflect the committed changes.