( )⚙ D3084 heads: add support for specying branches by revset

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3084

heads: add support for specying branches by revset
ClosedPublic

Authored by martinvonz on Apr 4 2018, 6:53 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG004e5c5821b2: heads: add support for specifying branches by revset
rHG924258526b12: heads: add support for specying branches by revset
Summary

Before this commit, e.g. "hg heads .^" would fail with:

abort: unknown revision '.^'!

Like the previous patch, I don't care about the command itself (I
don't think I had ever used it before), I'm just cleaning up uses of
repo[<string>].

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Apr 4 2018, 6:53 PM
indygreg accepted this revision.Apr 4 2018, 8:48 PM
This revision is now accepted and ready to land.Apr 4 2018, 8:48 PM
Closed by commit rHG924258526b12: heads: add support for specying branches by revset (authored by martinvonz). · Explain WhyApr 4 2018, 8:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (3 lines)

Diff 7658

mercurial/commands.py

heads = [repo[h] for h in repo.heads(start)] heads = [repo[h] for h in repo.heads(start)]
else: else:
heads = [] heads = []
for branch in repo.branchmap(): for branch in repo.branchmap():
heads += repo.branchheads(branch, start, opts.get('closed')) heads += repo.branchheads(branch, start, opts.get('closed'))
heads = [repo[h] for h in heads] heads = [repo[h] for h in heads]
if branchrevs: if branchrevs:
branches = set(repo[br].branch() for br in branchrevs) branches = set(repo[r].branch()
for r in scmutil.revrange(repo, branchrevs))
heads = [h for h in heads if h.branch() in branches] heads = [h for h in heads if h.branch() in branches]
if opts.get('active') and branchrevs: if opts.get('active') and branchrevs:
dagheads = repo.heads(start) dagheads = repo.heads(start)
heads = [h for h in heads if h.node() in dagheads] heads = [h for h in heads if h.node() in dagheads]
if branchrevs: if branchrevs:
haveheads = set(h.branch() for h in heads) haveheads = set(h.branch() for h in heads)