( )⚙ D3087 bookmarks: calculateupdate() returns a bookmark, not a rev

This is an archive of the discontinued Mercurial Phabricator instance.

bookmarks: calculateupdate() returns a bookmark, not a rev
ClosedPublic

Authored by martinvonz on Apr 4 2018, 6:53 PM.

Details

Summary

This changes the inaccurate/unclear documentation and also changes the
code so "node" now contains a binary nodeid.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 4 2018, 6:53 PM
yuja accepted this revision.Apr 5 2018, 9:23 AM
yuja added a subscriber: yuja.
yuja added inline comments.
mercurial/bookmarks.py
353

That's true only if checkout is None.

Perhaps we should remove the checkout argument. Can you send
a follow up?

This revision is now accepted and ready to land.Apr 5 2018, 9:23 AM
This revision was automatically updated to reflect the committed changes.