( )⚙ D3088 extdatasource: use revsymbol() for converting to node

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3088

extdatasource: use revsymbol() for converting to node
ClosedPublic

Authored by martinvonz on Apr 4 2018, 6:53 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHGd0d55980ffa7: extdatasource: use revsymbol() for converting to node
Summary

It's unclear what we want to support here. Perhaps it should just be
nodeids? It doesn't make much sense to share revnums between repos,
and bookmarks are probably too unstable. I used scmutil.revsymbol() to
preserve the current behavior. We can change later if we want to.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 4 2018, 6:53 PM
martinvonz edited the summary of this revision. (Show Details)Apr 5 2018, 1:37 AM
martinvonz retitled this revision from extdatasource: use repo.lookup() for converting to node to extdatasource: use revsymbol() for converting to node.
yuja accepted this revision.Apr 5 2018, 9:26 AM
yuja added a subscriber: yuja.

Perhaps it should just be nodeids?

I think it should be, but the test disagree. Maybe we can make BC since
it's still an experimental feature.

This revision is now accepted and ready to land.Apr 5 2018, 9:26 AM
Closed by commit rHGd0d55980ffa7: extdatasource: use revsymbol() for converting to node (authored by martinvonz). · Explain WhyApr 5 2018, 9:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/scmutil.py (2 lines)

Diff 7719

mercurial/scmutil.py

for l in src: for l in src:
if " " in l: if " " in l:
k, v = l.strip().split(" ", 1) k, v = l.strip().split(" ", 1)
else: else:
k, v = l.strip(), "" k, v = l.strip(), ""
k = encoding.tolocal(k) k = encoding.tolocal(k)
try: try:
data[repo[k].rev()] = encoding.tolocal(v) data[revsingle(repo, k).rev()] = encoding.tolocal(v)
except (error.LookupError, error.RepoLookupError): except (error.LookupError, error.RepoLookupError):
pass # we ignore data for nodes that don't exist locally pass # we ignore data for nodes that don't exist locally
finally: finally:
if proc: if proc:
proc.communicate() proc.communicate()
if src: if src:
src.close() src.close()
if proc and proc.returncode != 0: if proc and proc.returncode != 0: