( )⚙ D336 sshpeer: use peer interface

This is an archive of the discontinued Mercurial Phabricator instance.

sshpeer: use peer interface
ClosedPublic

Authored by indygreg on Aug 11 2017, 12:20 AM.

Details

Summary

We need the same @property conversion of ui like we did for localpeer.
We renamed _capabilities() to capabilities() to satisfy the new
naming requirement.

However, since we're inheriting from wireproto.wirepeer which inherits
from peer.peerrepository and provides its own code accessing
_capabilities(), we need to keep the old alias around. This wonkiness
will disappear once wirepeer is cleaned up in subsequent commits.

We also implement methods for basepeer that are identical to the
defaults in peer.peerrepository in preparation for the removal of
peerrepository.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Aug 11 2017, 12:20 AM
durin42 accepted this revision.Aug 11 2017, 2:28 PM
This revision is now accepted and ready to land.Aug 11 2017, 2:28 PM
This revision was automatically updated to reflect the committed changes.